Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert #875 #905

Merged
merged 1 commit into from
Aug 12, 2024
Merged

revert #875 #905

merged 1 commit into from
Aug 12, 2024

Conversation

technophile-04
Copy link
Collaborator

Description

Reverts the changes from #875.

The reason for #875 was scaffold-eth#55 (comment). Since in create-eth we are no more using prettier from outside to format files and instead using SE-2 instance prettier to format files we don't require this changes anymore.

The reason for reverting this is #901.

To see if this solve #901 :

Copy paste the below in page.tsx insde Home component:

Test snippet :
  const [count, setCount] = useState(0);
  const [name, setName] = useState("shiv");
  // should get an eslint error
  const x = "shiv";

  useEffect(() => {
    setCount(count + 1);
    console.log(count);
    setName("shiv");
    console.log(name);
    // should get an eslint warning 
  }, [count]);

And hopefully you should get eslint warning / error at mentioned places in the comment.

@MattPereira
Copy link
Contributor

@technophile-04 you are my hero 😍

image

@rin-st
Copy link
Member

rin-st commented Aug 9, 2024

Works great to me! And I agree that this solution is better because it's more stable! Thank you!

@technophile-04 technophile-04 merged commit 2eff0d4 into main Aug 12, 2024
1 check passed
@technophile-04 technophile-04 deleted the revert-prettier-commit branch August 12, 2024 02:18
@technophile-04
Copy link
Collaborator Author

Thanks all! Merging this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants