-
Notifications
You must be signed in to change notification settings - Fork 796
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(docs) Fixed the main frontend path in README #808
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch @kkomelin!! We updated it in docs but totally missed README!
In docs we changed the "Edit your frontend" line for:
- Edit your frontend homepage at
packages/nextjs/app/page.tsx
. For guidance on routing and configuring pages/layouts checkout the Next.js documentation.
Maybe we could use same explanation?
Yeah we can add it! Would love to check if it was not added for simplicity or if it's cool to add it with @carletex or @technophile-04 Maybe we can format it similarly to the docs as: What's next
|
Not remember completely but might be the reason, since we already had docs link below it But thinking a bit maybe we could add it what @Pabl0cks suggested (since we already have most of the points already present) Maybe we should keep "What's next" small (maybe bold) but not as heading Something like : Code :**What's next**:
- Edit your smart contract `YourContract.sol` in `packages/hardhat/contracts`
- Edit your frontend homepage at `packages/nextjs/app/page.tsx`. For guidance on [routing](https://nextjs.org/docs/app/building-your-application/routing/defining-routes) and configuring [pages/layouts](https://nextjs.org/docs/app/building-your-application/routing/pages-and-layouts) checkout the Next.js documentation.
- Edit your deployment scripts in `packages/hardhat/deploy`
- Edit your smart contract test in: `packages/hardhat/test`. To run test use `yarn hardhat:test` @kkomelin could you please update it? |
Yes! Totally. After sending my sample I was like.. maybe too big 😅 |
I'm on it guys, will update soon. |
@technophile-04 @Pabl0cks Just applied the changes you suggested. Please review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @kkomelin ! and also thanks all for great suggestions !
Thanks everyone for helping with that! |
Description
Previously the main frontend path was
nextjs/pages
. Now the project switched to the Next.js App Router and thenextjs/app
folder correspondingly. We need to update the README correspondingly.Additional Information