Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Goerli from supported networks #771

Merged
merged 3 commits into from
Mar 12, 2024

Conversation

Hotmanics
Copy link
Contributor

Description

Goerli has been effectively deprecated and is no longer supported by major RPC clients, thus we can safely remove it from the template as it appears as unnecessary fluff.

Additional Information

Your ENS/address: JacobHomanics.eth

@carletex
Copy link
Member

Thanks @Hotmanics!

Always feels good to remove stuff :D

Could you remove other appearances of goerli in the codebase?

  • Deploy script (see the commented section). Maybe switch for sepolia.
  • networks.ts on the next app

@Hotmanics
Copy link
Contributor Author

Thanks @Hotmanics!

Always feels good to remove stuff :D

Could you remove other appearances of goerli in the codebase?

  • Deploy script (see the commented section). Maybe switch for sepolia.
  • networks.ts on the next app

ah great! Did not realize it was in those places. Thanks!

This PR now accounts for those files!

Copy link
Collaborator

@rin-st rin-st left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Copy link
Collaborator

@technophile-04 technophile-04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Hotmanics , and also others for reviews and test looking good !

@technophile-04 technophile-04 merged commit 9b9fbaa into scaffold-eth:main Mar 12, 2024
1 check passed
@github-actions github-actions bot mentioned this pull request Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants