-
Notifications
You must be signed in to change notification settings - Fork 809
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cli add prettier task #750
Conversation
Also tagging @jrcarlos2000 just to verify if I added |
Looks good ! |
src/tasks/prettier-format.ts
Outdated
const result = await execa("yarn", ["format"], { cwd: targetDir }); | ||
|
||
if (result.failed) { | ||
throw new Error("There was a problem running the format commend"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo command
Great job Shiv! 👍 Tried to reproduce #748 For both foundry and hardhat it were an errors similar to described
but it was because no .env file and |
Ohh yeah it should be fixed once we create the main back merge PR Thanks all merging this 🙌 |
Description
Since we have
.template.mjs
file eg this. So when the whole project is scaffolded there are some prettier warning left for eg: #748 logs.This PR:
format
script in root package.json to format both hardhat and foundryforge fmt
.js
file with prettier also added.prettier.json
inpackages/foundry