fix local next build #749
Merged
fix local next build #749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
technophile-04
commented
Mar 2, 2024
1 task
Pabl0cks
approved these changes
Mar 3, 2024
There was a problem hiding this comment.
Great job @technophile-04!! yarn run build is working again on my Windows environment after your fix 🙌
TYSM
rin-st
approved these changes
Mar 3, 2024
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If you
cd packages/nextjsand runyarn buildit fails,The reason was
baseUrlwhich we were generating for metadata.This PR adds a fallback port, similar to how next
metadataBasedefault works.Btw we need
baseUrlsince OpenGraph.image and Twitter.image they both absoulte path and passing just/thumbnail.jpgdoes not work, check out code commet here.Closes #748