-
Notifications
You must be signed in to change notification settings - Fork 797
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix cursor stealing & display loading for AddressInput #738
Conversation
Love this @technophile-04 Thank you!! Left a couple a comments |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GJ @technophile-04, feels like magic!! Works pretty well in mobile too.
I feel a bit old saying that, but 900 seems ok to me 😅 Approving but will test again if you tweak the visual feedback while resolving.
Thanks Shiv, gj! Found one bug and it worked for every address I entered first time. Refocus is somewhere where ens domain ends (it seems the same length) 2024-02-23.18.53.48.mov |
Thanks all for the test's and review !!
Yup I agree reverted it back to 500 at 15cfdbf
Thanks ! Fixed at c2f1cf3
Going with this for showing loading, reason : This option really nicely handles layout shifting as compared to other option. Screen.Recording.2024-02-24.at.1.47.19.AM.movAlso the Ens Avatar loading until now it used to come, go, and then pop up again with the image |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good to me! Awesome job @technophile-04 🙌
Merging this 🙌 Tysm All ! |
Description
Reason for #710:
How AddressInput internally works:
Cause of the issue:
Solution:
Some minor tweak to imporve UX:
Demo:
Screen.Recording.2024-02-23.at.1.31.48.PM.mov
Closes #710