Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

latest cli back-merge #728

Merged
merged 14 commits into from
Feb 15, 2024
Merged

latest cli back-merge #728

merged 14 commits into from
Feb 15, 2024

Conversation

technophile-04
Copy link
Collaborator

@technophile-04 technophile-04 commented Feb 15, 2024

Description

@technophile-04
Copy link
Collaborator Author

I think we can get #726 changes also in for this backmerge

Also we shouldn't Squash and merge this PR instead do a normal merge

@technophile-04
Copy link
Collaborator Author

technophile-04 commented Feb 15, 2024

Merging this, tested it nicely too 🙌

PS: If someone encounters #719 (review) this issue, just close the whole browser and re-open it. I wasted a lot of time debugging/fixing with code but the straightforward solution was to close the whole browser and repo it, Again I think this should only occur to contributors of SE-2 only once as mentioned in #719 (comment)

@technophile-04 technophile-04 merged commit 6a25874 into cli Feb 15, 2024
@technophile-04 technophile-04 deleted the cli-backmerge branch February 15, 2024 10:20
@Pabl0cks Pabl0cks restored the cli-backmerge branch February 15, 2024 11:24
Copy link
Collaborator

@Pabl0cks Pabl0cks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job bringing all the changes to the cli @technophile-04 🙌!

Been testing it in hardhat and foundry, this is what I found:

  • CLI is installing an old Readme, i think we may need to update templates\base\README.md ?
  • Need to add arbitrumSepolia and optimismSepolia to foundry.toml
  • When deployed to Vercel, everything is working great except Address page from blockexplorer. A bit strange use case for this to happen (vercel + localhost). This happened in both Hardhat and Foundry
Here are my vercel logs for Foundry:

_Error: Directory /var/foundry/out/build-info not found.
at O (/var/task/.next/server/app/blockexplorer/address/[address]/page.js:1:8738)
at z (/var/task/.next/server/app/blockexplorer/address/[address]/page.js:1:9011)
at em (/var/task/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:12:128334)
at /var/task/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:12:140034
at Array.toJSON (/var/task/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:12:143612)
at stringify ()
at eE (/var/task/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:12:131997)
at eR (/var/task/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:12:132440)
at AsyncLocalStorage.run (node:async_hooks:338:14)
at Timeout.onTimeout (/var/task/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:12:144064)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants