Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove custom Spinner component #669

Merged
merged 2 commits into from
Dec 21, 2023

Conversation

swolidity
Copy link
Contributor

Description

Removed custom Spinner component and replaced with DaisyUI inbuilt component.

Additional Information

Related Issues

Closes #664

Your ENS/address:

swolidity.eth

@swolidity swolidity changed the title remove custom Spinner component (#664) remove custom Spinner component Dec 19, 2023
@technophile-04
Copy link
Collaborator

Hey thanks @swolidity for tackling it,

In notification loading there seems some extra space / padding below text :

Current version main branch version
Screenshot 2023-12-20 at 12 41 56 PM Screenshot 2023-12-20 at 12 40 34 PM

can we fix that? Thanks 🙌

You can just put this button in index.tsx under pages to test this :

<button
  className="btn btn-primary"
  onClick={() => {
    notification.loading("Wait for transaction", { duration: Infinity });
    notification.success("Completed for transaction", { duration: Infinity });
  }}
>
  Toast
</button>

@swolidity
Copy link
Contributor Author

Good catch @technophile-04 thank you! I just pushed a commit that should resolve this.

updated current version main branch version
Screenshot 2023-12-20 at 2 34 02 PM Screenshot 2023-12-20 at 2 35 58 PM

Copy link
Collaborator

@technophile-04 technophile-04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tysm @swolidity !! Look great !!

@technophile-04 technophile-04 merged commit 0bc8143 into scaffold-eth:main Dec 21, 2023
1 check passed
@github-actions github-actions bot mentioned this pull request Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove/ update the custom Spinner component
2 participants