-
Notifications
You must be signed in to change notification settings - Fork 797
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix displaying of custom solidity errors #638
Conversation
packages/nextjs/components/scaffold-eth/Contract/utilsContract.tsx
Outdated
Show resolved
Hide resolved
Works for me! Great job @technophile-04 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great improvement @technophile-04 !!
Everything looks great to me!
One small comment that is related to this change, but it really affects all the notifications. The text is cut in an unfriendly way at the end of each line, like for example on the second video:
"reas" -> "on" and "cu" -> "stom". Maybe changing the text-wrap CSS style is enough to fix it. Maybe we can create a new issue for this...
Ohh yes ! lol it has been bugging me too for a while, just removed word break
Like the I tried playing with some basic styles like adding positioning |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Added 1 small comment about removing the as any
. Besides that, it looks good to go 👍
The problem with this is that big strings without spaces go over the edge
If I apply Maybe we need to tweak something about the container? |
It seems that |
Ohh yes! Tysm for the solution it works great !!, updated at f7e960a |
Tysm all !! Merging this 🙌 |
Description
This problem occurs when you have custom solidity errors and you try to read/write from Debug page :
Test YourContract.sol
Before (
main
branch) :Screen.Recording.2023-12-03.at.12.13.17.AM.mov
After :
Screen.Recording.2023-12-03.at.12.05.25.AM.mov
Cause :
When passing
abi
to wagmi's native hooks we were just passing that function abi eg:abi: [functionABI]
because of which wagmi was not able to parse the errors.