Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weekly CLI backmerge #635

Merged
merged 12 commits into from
Dec 3, 2023
Merged

Weekly CLI backmerge #635

merged 12 commits into from
Dec 3, 2023

Conversation

technophile-04
Copy link
Collaborator

Description

NOTE: Need to test it properly and also we shouldn't squash & merge this instead do a normal merge

Copy link
Member

@rin-st rin-st left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@technophile-04
Copy link
Collaborator Author

Just found a small bug at [address].tsx it was broken and at 58bf26c updated [address].tsx to be a template.

Earlier we had this kindof fix in that file :

const configuredNetwork = getTargetNetwork();
`${configuredNetwork.network === "hardhat" ? "artifacts" : "out"}`

But after #615 we no more have getTargetNetwork and instead it gives array of networks I could have done configuredNetwork[0] but there might be a slight edge case where people put hardhat / foundry as not the 0th chain and this would break blockexplorer.

Also in [address].tsx there were many places hardcode hardhat even though if you select foundry, I mean they both have the same configuration but now after 58bf26c [address.tsx] is kind of better at least in readability.

Tested it nicely, Merging this 🙌

@technophile-04 technophile-04 merged commit fccc54e into cli Dec 3, 2023
@technophile-04 technophile-04 deleted the cli-backmerge branch December 3, 2023 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants