Add event logs to transaction page #591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rin-st
reviewed
Oct 29, 2023
rin-st
reviewed
Oct 29, 2023
technophile-04
approved these changes
Oct 30, 2023
|
Tysm Damu, Merging this 🙌 |
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add event logs to the transaction page.
I added only the topics since I think all the important log information is already on the transaction data. Please let me know if you think I should add something more.
We should try to show the topics information in a prettier way, adding the event name and the parameters names, and decoding the data. Here and in the contract logs page too, but this is for another issue ;-)
Additional Information
Your ENS/address: damianmarti.eth