Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add copy to clipboard to TxReceipt #590

Merged
merged 2 commits into from
Oct 30, 2023
Merged

Conversation

damianmarti
Copy link
Collaborator

Description

Add copy to clipboard to transaction receipt to allow to copy the transaction data easily.

localhost_3002_debug

Additional Information

Your ENS/address: damianmarti.eth

Copy link
Collaborator

@technophile-04 technophile-04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice !! LGTM !

Thanks @damianmarti 🙌

@carletex
Copy link
Member

Nice! Thanks @damianmarti

The only thing that I'd explore is to position the copy icon in a different place (rn It feels a bit in the middle of nowhere)

The standard seems to be on the top right, but since we already have the arrow, might look a bit weird:
image

Another option could be next to the title:
image

We'd have to tweak a bit since that whole "row" collapses the result on click.


Anyway, just a suggestion, not a big deal if we keep it as it is!

@damianmarti
Copy link
Collaborator Author

@carletex yeah, I know, it's not the best place.

Next to the title is the best option, but we should remove the row collapse by clicking the header and moving it to only the arrow.

I will try it!

@damianmarti
Copy link
Collaborator Author

@carletex what do you think now?

localhost_3002_debug (1)

The receipt is copied by clicking the copy icon and the receipt is expanded if you click anywhere else.

localhost_3002_debug (2)

Copy link
Member

@rin-st rin-st left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@carletex
Copy link
Member

Thanks @damianmarti !!!

I think this looks better.

@carletex carletex merged commit b5347f7 into main Oct 30, 2023
1 check passed
@carletex carletex deleted the add-tx-receipt-copy-to-clipboard branch October 30, 2023 10:29
@carletex carletex mentioned this pull request Nov 2, 2023
@github-actions github-actions bot mentioned this pull request Nov 2, 2023
@technophile-04 technophile-04 mentioned this pull request Nov 13, 2023
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants