fix: incorrect error when sending txn with insufficient funds #584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damianmarti
approved these changes
Oct 24, 2023
There was a problem hiding this comment.
Nice catch @technophile-04 !!!
The fix looks good, but maybe we can wait a little if Wagmi fixes the bug.
rin-st
reviewed
Oct 24, 2023
packages/nextjs/components/scaffold-eth/Contract/WriteOnlyFunctionForm.tsx
Show resolved
Hide resolved
rin-st
approved these changes
Oct 25, 2023
|
Thanks @technophile-04 ! And thanks for the review. Yep, maybe we don't need I guess we do need it on the Read hooks (in case no wallet is connected) and ofc in the ENS ones (where we always want to look up mainnet) |
Merged
Merged
This was referenced Nov 1, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In summary, we get this error :
While sending
valuei.e greater than our wallet balance, Ideally it should have given us "Sender doesn't have enought fund...." errorCheck out wevm/viem#1457 for full context
Removing
chainIdfromuseContractWritesolves this problem, We could also wait until wevm/viem#1457 is fixed and close this 🙌