Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add types to even data in useScaffoldEventHistory #553

Merged
merged 6 commits into from
Oct 3, 2023

Conversation

technophile-04
Copy link
Collaborator

Description

Added types to event data in useScaffoldEventHistory hook previously it was just any[].

Demo :

Screen.Recording.2023-10-01.at.11.19.01.PM.mov

@rin-st
Copy link
Member

rin-st commented Oct 1, 2023

Looks great! And thanks for the video!

Copy link
Collaborator

@damianmarti damianmarti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks @technophile-04 !!

Copy link
Collaborator

@sverps sverps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks clean! Nice work ❤️

@carletex
Copy link
Member

carletex commented Oct 3, 2023

Amazing stuff!! <3

@technophile-04
Copy link
Collaborator Author

Merging this thanks all 🙌

@technophile-04 technophile-04 merged commit 55f64ce into main Oct 3, 2023
1 check passed
@technophile-04 technophile-04 deleted the feat/useScaffoldHistory-types branch October 3, 2023 13:42
@github-actions github-actions bot mentioned this pull request Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants