Move from react-blockies to blo #538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks really good @bpierre. Thanks!! Good job building the lib ;) Let us test a bit more & do a quick due diligence and will merge. |
technophile-04
approved these changes
Sep 21, 2023
There was a problem hiding this comment.
Tysm @bpierre, This is really great !!
It indeed renders identicons nicely and more correctly!
| blo | react-blockies |
|---|---|
The above images are when you use Address component with size="2xl", blo example looks complete accurate as compared to react-blockies
Look really good to me !
Just cc @carletex(edit : lol he already commented) @rin-st @damianmarti once since it is a pretty new libraray, but on my testing everything worked similarly to react-blockies 🙌
|
Awesome 🥳 💕 |
|
Looks good to me 👍 |
rin-st
approved these changes
Sep 21, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Move from react-blockies to blo, for a faster and more precise rendering of the identicons.
Before:
After:
Before:
After:
Before:
After:
Additional Information
My ENS/address: pierre.eth