Update and typescript version #499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rin-st
approved these changes
Aug 23, 2023
damianmarti
approved these changes
Aug 25, 2023
There was a problem hiding this comment.
LGTM but I think it is better that @sverps looks at it before merging.
sverps
approved these changes
Aug 28, 2023
This was referenced Sep 5, 2023
damianmarti
pushed a commit
that referenced
this pull request
Sep 7, 2023
* Fix RainbowKitCustomConnectButton dropdown styles (#500) * chore: footer missalignment & home page on small screens (#502) Co-authored-by: CJ <53488449+0xChijoke@users.noreply.github.com> * Update and typescript version (#499) * update typescript and viem version * update next config * fix: header links wrapping icons and text (#510) * Fix typos in useScaffoldContractWrite logs (#512) * fix: spelling in test file name (#522) * add suport for verify in foundry similar to hardhat * update git task title when using foundry * add changeset * update changeset --------- Co-authored-by: Rinat <rinat@hey.com> Co-authored-by: CJ <53488449+0xChijoke@users.noreply.github.com> Co-authored-by: Zak G <zakgriffith@gmail.com>
Merged
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
So after a lot of digging, I landed on how to two versions of same npm package and for some reason, I am not able to find that particular link but people were trying to have kind of same typescript version. Which led to me thinking that the reason
yarn next:check-typesmight be checkingnode_modulesas discussed in #492 is becauseviemis using typescript version5+So the steps I followed to fix #492 :
Updated
viemversion to latest usingyarn workspace @se-2/nextjs up viemI did
yarn next:check-typeshere I got678 errorsmostly fromnode_modules/viemyarn workspace @se-2/nextjs up typescript(For some reason this also updated hardhat typescript version which is ok I think nd kind of makes sense)Again
yarn next:check-typesit now gave me only errors from Se-2 repo regardingAddressTypeUpdated
abi.d.ts, to also handleviem/node_modules/abitypeand haveAddressType : stringAgain
yarn next:check-typesand lol no types error at all!!Started with manual testing and found that nextjs app broke with "Cannot find
fsmodule error", after some digging found this on Rainbowkit installation Page :So I added nextjs config which they linked on their installation Page and everything started working. I don't why we didn't have to do it before.
My wild guess is something heavily changed inside
viemwhich kind of removed exposingethersto outter world and we got that error becauseviemis internally usingetherssomewhere, check its dependencies here.Lol I didn't particularly know what was actual cause, so explained all the steps if someone can infer something from it 🙌.
I need to do some testing nicely, will do it tomorrow and would appreciate it if others could test as well 🙌
Also please feel free to share your thoughts !!
Additional Information
Related Issues
#492
Your ENS/address: shivbhonde.eth