Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add compatibility with SAFE #346

Merged
merged 8 commits into from
Sep 30, 2023
Merged

add compatibility with SAFE #346

merged 8 commits into from
Sep 30, 2023

Conversation

technophile-04
Copy link
Collaborator

Description

It would be really great if we make SE-2 compatible with Gnosis SAFE by default as soon as it's deployed.

Screen.Recording.2023-05-14.at.5.10.34.PM.mov

Try adding it as a custom app on SAFE goerli -> https://xx-ecru.vercel.app

Note: To make it work you have to deploy your Dapp first. It won't work if you are running localhost, we can make it work but we may need to configure CORS https://docs.safe.global/learn/safe-apps/get-started#cors and I think CORS options suggested in safe-docs are a bit harsh and don't like setting them as default in SE-2.

I originally added it to ETH-Splitter and thought it might be great if we provide SAFE compatibility out of the box , but feel free to close it 🙌

Additional Information

Your ENS/address: shivbhonde.eth

@austintgriffith
Copy link
Contributor

austintgriffith commented Sep 28, 2023

I came here to post this same issue. It would be great if SE2 builds worked as safe apps out of the box.

👀 maybe it already is!

@technophile-04
Copy link
Collaborator Author

I think this PR is ready to merge 🙌, updated the logic so now its alot simpler and direct

Here is the test app link : https://safe-goerli.vercel.app (can be tested on gorerli safe

I also tested auto connect nicely just to be sure that we don't break anything 🙌

@rin-st
Copy link
Member

rin-st commented Sep 29, 2023

Gj!
Question: Should it show safe when I'm disconnected?

@technophile-04
Copy link
Collaborator Author

Question: Should it show safe when I'm disconnected?

didn't get this 😅, like when you disconnect it will disconnect and when you click connect wallet it will show Safe wallet as an option(just pushed this changes) :

Screen.Recording.2023-09-30.at.7.55.17.PM.mov

Also notice Safe wallet will only be shown if you open it in safe iframe, it wont show if you open https://safe-goerli.vercel.app/ in normal browser tab which is great 🙌

@technophile-04
Copy link
Collaborator Author

Tysm all for review merging this 🙌

@technophile-04 technophile-04 merged commit 6664883 into main Sep 30, 2023
1 check passed
@technophile-04 technophile-04 deleted the feat/compataible-safe branch September 30, 2023 15:44
Anurag-Raut added a commit to Anurag-Raut/se-2 that referenced this pull request Sep 30, 2023
add out of box compatibility with SAFE{Wallet} (scaffold-eth#346)
Anurag-Raut added a commit to Anurag-Raut/se-2 that referenced this pull request Sep 30, 2023
add out of box compatibility with SAFE{Wallet} (scaffold-eth#346)
@github-actions github-actions bot mentioned this pull request Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants