Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add polygonZkEvm and polygonZkEvmTestnet and update wagmi/core #309

Merged
merged 8 commits into from
Sep 13, 2023

Conversation

OwlWilderness
Copy link
Contributor

@OwlWilderness OwlWilderness commented Apr 19, 2023

#310 Add polygonZkEvm and polygonZkEvmTestnet and update wagmi/core

  • updated hardhat config ts to include zkevm main and test net
  • updated wagmi/core to 12.10

@OwlWilderness OwlWilderness marked this pull request as ready for review April 19, 2023 03:22
@OwlWilderness
Copy link
Contributor Author

OwlWilderness commented Apr 19, 2023

Hi - this is my first functional PR - please guide me if i need to add / remove anything (like is the yarn.lock supposed to be included??)

Also not sure where I am supposed to tag or add reviewers so I will here - Hi @austintgriffith could you guide me here? thanks. (do I need to create a work item to associate?)

@sverps
Copy link
Collaborator

sverps commented Apr 19, 2023

yarn.lock should indeed be included 👍
Files that shouldn't be included are generally added to .gitignore already.

Will play around a bit with it to see if there's anything that needs to be taken into account with the wagmi update, but the PR looks clean 👍

@OwlWilderness
Copy link
Contributor Author

Thank you @sverps for your feedback!

Please note I only deployed to testnet - working on bridging to deploy to mainnet tonight. (I probably should have waited to raise the pr until then maybe).
I also haven't worked out verify but not sure if that is just a api-key issue.

Thanks

@technophile-04
Copy link
Collaborator

technophile-04 commented Apr 19, 2023

Tysm @OwlWilderness, I think we should be really be conscious of package updation especially wagmi because we have overridden some types and not rely on the migration guide 😅,

Saying this because I think Wagmi 0.12.8 have again broke AddressType checkout -> wevm/wagmi#1712 (comment)

Please note I only deployed to testnet - working on bridging to deploy to mainnet tonight. (I probably should have waited to raise the pr until then maybe).

Yup it would be really great if we get verify working

Marking this as a draft until we get verify working and wagmi fixes bug or maybe we downgrade it to 0.12.8(where polygonZKvm was added)....please feel free to mark it as Ready for review whenever its ready

@technophile-04 technophile-04 marked this pull request as draft April 19, 2023 16:10
@OwlWilderness
Copy link
Contributor Author

Hi @technophile-04
Thank you for your help. I've started to update the related issue (#310) with this feedback- and I will update as I deploy and verify. Thanks

@technophile-04 technophile-04 marked this pull request as ready for review September 13, 2023 16:38
@technophile-04 technophile-04 linked an issue Sep 13, 2023 that may be closed by this pull request
Copy link
Collaborator

@technophile-04 technophile-04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey tysm @OwlWilderness 🙌, We actually updated the wagmi version so reverted the other changes and just kept the hardhat.config.ts changes

@technophile-04 technophile-04 merged commit 30383ba into scaffold-eth:main Sep 13, 2023
1 check passed
@OwlWilderness
Copy link
Contributor Author

Thank you @technophile-04! I knew wagmi was going in and thought to update this PR but wasn't paying too much attention - so I really appreciate you reverting those commits and merging this.

@github-actions github-actions bot mentioned this pull request Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

se-2 integrate polygon zkevm main and test net
3 participants