New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: make contract and hook types work without a generated output #255

Merged

carletex merged 9 commits into main from feature/254-no-contracts-mode

Mar 24, 2023

Collaborator

sverps commented Mar 23, 2023

Fixes #254

A dev that doesn't need any custom contract can simply remove the hardhat_contracts.ts import in the scaffold.config, and set contracts: null.

Typescript won't complain due to types resolving differently when contracts is set to null in the config.


          feat: make contract and hook types work without a generated output

450c827

Fixes #254

sverps requested review from carletex, rin-st and technophile-04

March 23, 2023 22:29

technophile-04 marked this pull request as ready for review

March 24, 2023 03:49

technophile-04 marked this pull request as draft

March 24, 2023 03:51

sverps mentioned this pull request

Vercel builds fails #254

Closed

carletex reviewed

View reviewed changes

packages/nextjs/scaffold.config.ts Show resolved Hide resolved

carletex reviewed

View reviewed changes

packages/nextjs/scaffold.config.ts Show resolved Hide resolved

sverps added 2 commits

March 24, 2023 11:30


          build: contract generation cleanup

8e2380e


          fix: create target dir if needed

385b1ee

carletex reviewed

View reviewed changes

packages/nextjs/scaffold.config.ts Show resolved Hide resolved


          Faucet & autoconnect check

43f82e5

carletex reviewed

View reviewed changes

packages/nextjs/hooks/scaffold-eth/useAutoConnect.ts Outdated Show resolved Hide resolved

carletex and others added 3 commits

March 24, 2023 11:51


          Comment

db5d16b


          fix: improve comment and only mkdir if it doesn't exist

d6c7e02


          fix: args should also be defined on the write hook when contracts is …

8f0a395

…null

carletex reviewed

View reviewed changes

packages/hardhat/scripts/generateTsAbis.ts Show resolved Hide resolved


          fix: remove hardhat-contracts.json file after it was used to generate…

0eb0663

… ts abi

carletex marked this pull request as ready for review

March 24, 2023 11:11


          fix: since generateTsAbi isn't supposed the be run directly, I remove…

f6e1ef6

…d it to avoid any confusion

Collaborator Author

sverps commented Mar 24, 2023

Found another confusing thing: the generateTsAbi script just spits out an error when called directly (which is logical since the json doesn't exist). This can be rather confusing for a user that is exploring which scripts exist in the package.json. He might not understand that this script is only used as part of the deploy and is not to be used directly (even though the name suggests it could).

So I removed the separate script for it and just added it to the deploy script instead.

Member

carletex commented Mar 24, 2023

So I removed the separate script for it and just added it to the deploy script instead.

Yep, nice one. Make sense!

This looks great. Merging it.

Thank you @sverps

carletex merged commit 84aa60c into main

carletex deleted the feature/254-no-contracts-mode branch

March 24, 2023 11:25

carletex mentioned this pull request

Generate empty hardhat_contract.ts file on postinstall #260

Merged

carletex mentioned this pull request

bug: deployedContracts file being out of sync #369

Closed

technophile-04 mentioned this pull request

better handling of deployments #666

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet