Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibility to change files required for onchainkit extension #74

Merged
merged 15 commits into from
Jul 25, 2024

Conversation

rin-st
Copy link
Member

@rin-st rin-st commented Jul 2, 2024

@technophile-04
Copy link
Collaborator

Thanks @rin-st !!! Maybe let's try to update to latest version of Onchainkit? I think fixed the colors clashing thier? I also see they mentioned that we don't need to update tailwind.config here?

Just trying to keep the .template.mjs files as minimal as possible because they can grow exponentially and cause problems in future. Obviously wherever required we have to add them, but just trying to be mindful before adding new ones

@rin-st
Copy link
Member Author

rin-st commented Jul 24, 2024

Yes, currently working on it 🙂

I think fixed the colors clashing their?

Almost, see last comment

I also see they mentioned that we don't need to update tailwind.config coinbase/onchainkit#852 (comment)?

Yes, but looks like we still need these two lines. Figuring it out, will answer a little bit later

@rin-st
Copy link
Member Author

rin-st commented Jul 24, 2024

but looks like we still need these two lines. Figuring it out, will answer a little bit later

No, removed it

I think these extension pr's are ready to merge. Onchainkit version is ^0.26.0 so styles will be fixed on update automatically.

Or we can wait to be sure but I think it's not critical

@rin-st
Copy link
Member Author

rin-st commented Jul 25, 2024

Onchainkit version is ^0.26.0 so styles will be fixed on update automatically.
Or we can wait to be sure but I think it's not critical

Fixed in 0.26.3, version is updated

Copy link
Collaborator

@technophile-04 technophile-04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rin-st !! This is great!! Tested and everything works nicely also current version doesn't break, Merging this 🙌

@technophile-04 technophile-04 merged commit 6d21542 into main Jul 25, 2024
1 check passed
@technophile-04 technophile-04 deleted the onchainkit-extension branch July 25, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants