-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Possibility to change files required for onchainkit extension #74
Conversation
templates/base/packages/nextjs/components/ScaffoldEthAppWithProviders.tsx.template.mjs
Show resolved
Hide resolved
Thanks @rin-st !!! Maybe let's try to update to latest version of Onchainkit? I think fixed the colors clashing thier? I also see they mentioned that we don't need to update Just trying to keep the |
Yes, currently working on it 🙂
Almost, see last comment
Yes, but looks like we still need these two lines. Figuring it out, will answer a little bit later |
a23c885
to
d0b918c
Compare
No, removed it I think these extension pr's are ready to merge. Onchainkit version is Or we can wait to be sure but I think it's not critical |
Fixed in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @rin-st !! This is great!! Tested and everything works nicely also current version doesn't break, Merging this 🙌
Extension PR: scaffold-eth/create-eth-extensions#11