Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup base package.json + fix foundry gh action #60

Merged
merged 4 commits into from
Jun 19, 2024
Merged

Conversation

technophile-04
Copy link
Collaborator

@technophile-04 technophile-04 commented Jun 19, 2024

Description:

  • remove unnecessary stuff from base package.json + vercel ignore from root
  • add gitignore inside deployments + remove unecessary workflow from foundry package

For 2nd point checkout #43 (comment), although CLI generated deployments/31337.json dir but while pushing it to github the whole deployments dir was not tracked since 31337.json is only file in deployments and was ignored too and this causes the yarn deploy to fail in github actions (since deployments dir is not present on github). But yarn deploy works nicely locally since its generated by CLI and then ignored with .gitignore.

To make yarn deploy work in foundry we need to make sure atleast empty deployments is present (something we could fix in scaffold-eth#867 or after in other PR) but for now I think this is fine.

Copy link
Member

@rin-st rin-st left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and it working great, thanks!

@carletex carletex merged commit 7f6f740 into main Jun 19, 2024
1 check passed
@carletex carletex deleted the minor-fix-cleanup branch June 19, 2024 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants