Cache sbt build artifacts across CI runs #273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed step to install Java to actions/setup-java instead of olafurpg/setup-scala, switch to the temurin distribution, and enable sbt caching.
eed3si9n
approved these changes
Jun 1, 2023
eed3si9n
approved these changes
Jun 1, 2023
eed3si9n
reviewed
Jun 1, 2023
| @@ -10,7 +10,11 @@ jobs: | |||
| - uses: actions/checkout@v3 | |||
| with: | |||
| fetch-depth: 0 | |||
| - uses: olafurpg/setup-scala@v14 | |||
| - uses: actions/setup-scala@v3 | |||
There was a problem hiding this comment.
There's a typo here that broke release. it should be actions/setup-java
https://github.com/sbt/sbt-ci-release/actions/runs/5145242446/jobs/9262621172
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed step to install Java to actions/setup-java instead of olafurpg/setup-scala, switch to the temurin distribution, and enable sbt caching.
The main motivation for this change is that the workflow
release.ymlis linked as an example from the documentation. I think it is important to have it up to date and efficient.