optimize namespace lookups #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks |
|
Will be included in 0.23.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On clusters with a lot of namespaces (over 1,000), I've been noticing some lag when running
kubie nswith no arguments.It's currently performing a namespace lookup twice in this scenario: once with every call to
namespace(), and then another one withinselect_or_list_namespace().Since the first namespace lookup is only needed when a namespace argument is provided and validation is enabled, this PR moves the namespace lookup into that match arm. This has resulted in
kubie nsrunning ~2x faster.This should also address #208.