Allow plugin to use the AWS Profile specified #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a getCredentials() method used in the options() to check if a profile is set in serverless.yml and use it if set, otherwise set credentials to null and fallback to default. Not fully tested.
|
@sbstjn Anything else I can do to get this merged in? |
|
Thanks for the PR! A friendly reminder was all you needed ;) |
|
|
|
It's not that simple :( The declarations for |
|
That's unfortunate. I'll see if I can make a PR over there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a getCredentials() method used in the options() to check if a profile is set in serverless.yml and use it if set, otherwise set credentials to null and fallback to default. Not fully tested.