Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select Steam ID as default Ban Type on PasteBan action #632

Merged
merged 1 commit into from
Feb 1, 2020

Conversation

borzaka
Copy link
Contributor

@borzaka borzaka commented Nov 5, 2019

Description

Steam ID is the most effective ban type, and btw Sleuth will catch a player on the same IP.

Motivation and Context

PasteBan action used, when you rightclick a player and select Ban/Block Comms. A form is automatically filled out with the players data. Without my modification is will select Ban Type: IP Address.
I think a few people would use IP Address as a primary Ban Type.

How Has This Been Tested?

Modified the corresponding file on my webserver, and used right click / Ban a player, and Steam ID was selected instead of IP Address.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.

Steam ID is the most effective ban type, and btw Sleuth will catch a player on the same IP.
@CrazyHackGUT
Copy link
Contributor

I think, it should be moved in options.

@borzaka
Copy link
Contributor Author

borzaka commented Nov 7, 2019

Yes, it would be nice to move this into a global option, but every other time you want to issue a ban, the Ban Type defaults to Steam ID. So this is just an update to make the Ban Type consistent everywhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants