This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
Enhanced the cohesion of the Account class by grouping related elements to specific classes [ TLS + Media] #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the pull request. However, this GitHub repository is only used as a mirror. Please submit your patches using gerrit: https://gerrit-ring.savoirfairelinux.com |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The class Account had 192 methods among which many were not really related or at least could be grouped in different classes. So we've created new classes for instance AccountTLS and AccountMedia in order to group related elements, so that the code will be more readable, maintainable. In addition the cohesion of the newly formed class will be higher.