Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix future incompatibility report #28

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ctrlcctrlv
Copy link

Cf. raphlinus#1

The following warnings were discovered during the build. These warnings are an indication that the packages contain code that will become an error in a future release of Rust. These warnings typically cover changes to close soundness problems, unintended or undocumented behavior, or critical problems that cannot be fixed in a backwards-compatible fashion, and are not expected to be in wide use.
Each warning should contain a link for more information on what the warning means and how to resolve it.
To solve this problem, you can try the following approaches:

  • If the issue is not solved by updating the dependencies, a fix has to be implemented by those dependencies. You can help with that by notifying the maintainers of this problem (e.g. by creating a bug report) or by proposing a fix to the maintainers (e.g. by creating a pull request):
  • If waiting for an upstream fix is not an option, you can use the [patch] section in Cargo.toml to use your own version of the dependency. For more information, see:
    https://doc.rust-lang.org/cargo/reference/overriding-dependencies.html#the-patch-section

The package nfd v0.0.4 (https://github.com/raphlinus/nfd-rs?rev=5e09b79bf511e3a91ae8cefdb96e9734fa4a79c2#5e09b79b) currently triggers the following future incompatibility lints:

warning: trailing semicolon in macro used in expression position
--> /home/fred/.cargo/git/checkouts/nfd-rs-c8063fc3bb0fe80d/5e09b79/build.rs:29:47
|
29 | concat!("nativefiledialog/src/", $suf);
| ^
...
37 | cfg.include(nfd!("include"));
| --------------- in this macro invocation
|
= warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
= note: for more information, see issue #79813 rust-lang/rust#79813
= note: #[allow(semicolon_in_expressions_from_macros)] on by default
= note: this warning originates in the macro nfd (in Nightly builds, run with -Z macro-backtrace for more info)

warning: trailing semicolon in macro used in expression position
--> /home/fred/.cargo/git/checkouts/nfd-rs-c8063fc3bb0fe80d/5e09b79/build.rs:29:47
|
29 | concat!("nativefiledialog/src/", $suf);
| ^
...
38 | cfg.file(nfd!("nfd_common.c"));
| -------------------- in this macro invocation
|
= warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
= note: for more information, see issue #79813 rust-lang/rust#79813
= note: #[allow(semicolon_in_expressions_from_macros)] on by default
= note: this warning originates in the macro nfd (in Nightly builds, run with -Z macro-backtrace for more info)

warning: trailing semicolon in macro used in expression position
--> /home/fred/.cargo/git/checkouts/nfd-rs-c8063fc3bb0fe80d/5e09b79/build.rs:29:47
|
29 | concat!("nativefiledialog/src/", $suf);
| ^
...
41 | cfg.file(nfd!("nfd_cocoa.m"));
| ------------------- in this macro invocation
|
= warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
= note: for more information, see issue #79813 rust-lang/rust#79813
= note: #[allow(semicolon_in_expressions_from_macros)] on by default
= note: this warning originates in the macro nfd (in Nightly builds, run with -Z macro-backtrace for more info)

warning: trailing semicolon in macro used in expression position
--> /home/fred/.cargo/git/checkouts/nfd-rs-c8063fc3bb0fe80d/5e09b79/build.rs:29:47
|
29 | concat!("nativefiledialog/src/", $suf);
| ^
...
46 | cfg.file(nfd!("nfd_win.cpp"));
| ------------------- in this macro invocation
|
= warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
= note: for more information, see issue #79813 rust-lang/rust#79813
= note: #[allow(semicolon_in_expressions_from_macros)] on by default
= note: this warning originates in the macro nfd (in Nightly builds, run with -Z macro-backtrace for more info)

warning: trailing semicolon in macro used in expression position
--> /home/fred/.cargo/git/checkouts/nfd-rs-c8063fc3bb0fe80d/5e09b79/build.rs:29:47
|
29 | concat!("nativefiledialog/src/", $suf);
| ^
...
72 | cfg.file(nfd!("nfd_gtk.c"));
| ----------------- in this macro invocation
|
= warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
= note: for more information, see issue #79813 rust-lang/rust#79813
= note: #[allow(semicolon_in_expressions_from_macros)] on by default
= note: this warning originates in the macro nfd (in Nightly builds, run with -Z macro-backtrace for more info)

The following warnings were discovered during the build. These warnings are an
indication that the packages contain code that will become an error in a
future release of Rust. These warnings typically cover changes to close
soundness problems, unintended or undocumented behavior, or critical problems
that cannot be fixed in a backwards-compatible fashion, and are not expected
to be in wide use.
Each warning should contain a link for more information on what the warning
means and how to resolve it.
To solve this problem, you can try the following approaches:
- If the issue is not solved by updating the dependencies, a fix has to be
implemented by those dependencies. You can help with that by notifying the
maintainers of this problem (e.g. by creating a bug report) or by proposing a
fix to the maintainers (e.g. by creating a pull request):
  - nfd@0.0.4
  - Repository: https://www.github.com/saurvs/nfd-rs
  - Detailed warning command: `cargo report future-incompatibilities --id 226 --package nfd@0.0.4`
- If waiting for an upstream fix is not an option, you can use the `[patch]`
section in `Cargo.toml` to use your own version of the dependency. For more
information, see:
https://doc.rust-lang.org/cargo/reference/overriding-dependencies.html#the-patch-section

The package `nfd v0.0.4 (https://github.com/raphlinus/nfd-rs?rev=5e09b79bf511e3a91ae8cefdb96e9734fa4a79c2#5e09b79b)` currently triggers the following future incompatibility lints:
> warning: trailing semicolon in macro used in expression position
>   --> /home/fred/.cargo/git/checkouts/nfd-rs-c8063fc3bb0fe80d/5e09b79/build.rs:29:47
>    |
> 29 |         concat!("nativefiledialog/src/", $suf);
>    |                                               ^
> ...
> 37 |     cfg.include(nfd!("include"));
>    |                 --------------- in this macro invocation
>    |
>    = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
>    = note: for more information, see issue #79813 <rust-lang/rust#79813>
>    = note: `#[allow(semicolon_in_expressions_from_macros)]` on by default
>    = note: this warning originates in the macro `nfd` (in Nightly builds, run with -Z macro-backtrace for more info)
>
> warning: trailing semicolon in macro used in expression position
>   --> /home/fred/.cargo/git/checkouts/nfd-rs-c8063fc3bb0fe80d/5e09b79/build.rs:29:47
>    |
> 29 |         concat!("nativefiledialog/src/", $suf);
>    |                                               ^
> ...
> 38 |     cfg.file(nfd!("nfd_common.c"));
>    |              -------------------- in this macro invocation
>    |
>    = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
>    = note: for more information, see issue #79813 <rust-lang/rust#79813>
>    = note: `#[allow(semicolon_in_expressions_from_macros)]` on by default
>    = note: this warning originates in the macro `nfd` (in Nightly builds, run with -Z macro-backtrace for more info)
>
> warning: trailing semicolon in macro used in expression position
>   --> /home/fred/.cargo/git/checkouts/nfd-rs-c8063fc3bb0fe80d/5e09b79/build.rs:29:47
>    |
> 29 |         concat!("nativefiledialog/src/", $suf);
>    |                                               ^
> ...
> 41 |         cfg.file(nfd!("nfd_cocoa.m"));
>    |                  ------------------- in this macro invocation
>    |
>    = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
>    = note: for more information, see issue #79813 <rust-lang/rust#79813>
>    = note: `#[allow(semicolon_in_expressions_from_macros)]` on by default
>    = note: this warning originates in the macro `nfd` (in Nightly builds, run with -Z macro-backtrace for more info)
>
> warning: trailing semicolon in macro used in expression position
>   --> /home/fred/.cargo/git/checkouts/nfd-rs-c8063fc3bb0fe80d/5e09b79/build.rs:29:47
>    |
> 29 |         concat!("nativefiledialog/src/", $suf);
>    |                                               ^
> ...
> 46 |         cfg.file(nfd!("nfd_win.cpp"));
>    |                  ------------------- in this macro invocation
>    |
>    = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
>    = note: for more information, see issue #79813 <rust-lang/rust#79813>
>    = note: `#[allow(semicolon_in_expressions_from_macros)]` on by default
>    = note: this warning originates in the macro `nfd` (in Nightly builds, run with -Z macro-backtrace for more info)
>
> warning: trailing semicolon in macro used in expression position
>   --> /home/fred/.cargo/git/checkouts/nfd-rs-c8063fc3bb0fe80d/5e09b79/build.rs:29:47
>    |
> 29 |         concat!("nativefiledialog/src/", $suf);
>    |                                               ^
> ...
> 72 |         cfg.file(nfd!("nfd_gtk.c"));
>    |                  ----------------- in this macro invocation
>    |
>    = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
>    = note: for more information, see issue #79813 <rust-lang/rust#79813>
>    = note: `#[allow(semicolon_in_expressions_from_macros)]` on by default
>    = note: this warning originates in the macro `nfd` (in Nightly builds, run with -Z macro-backtrace for more info)
>
@littleBitsman
Copy link

bump - I'd like for this to be merged just because seeing that little warning that a dependency will become incompatible with Rust is annoying

@o-dka
Copy link

o-dka commented Apr 30, 2024

bump, for the same reason.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants