-
-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Path test failure with Python 3.12 #1934
Comments
Oh man, that is tricky news. Thank you so much for the heads up. Frustrating that that was not included here: https://docs.python.org/3.12/whatsnew/3.12.html#pathlib |
I believe this is the relevant PR: python/cpython#102476 |
@QuLogic are you able to test the It seems like Python 3.12 is not supported by conda yet, or I would test it myself. |
(And I really do appreciate you letting us know.) |
`pathlib.Path._parts` has been removed in Python 3.12: python/cpython#102476 Switch to pathlib.Path.parts which is a tuple. Closes #1934
Thanks for the quick fix! I backported the patch and the build with Python 3.12 succeeded: https://koji.fedoraproject.org/koji/taskinfo?taskID=102650843 |
@QuLogic Ahhhhh, thank you! We will prepare a patch release of VisiData! |
`pathlib.Path._parts` has been removed in Python 3.12: python/cpython#102476 Switch to pathlib.Path.parts which is a tuple. Closes #1934
`pathlib.Path._parts` has been removed in Python 3.12: python/cpython#102476 Switch to pathlib.Path.parts which is a tuple. Closes #1934
`pathlib.Path._parts` has been removed in Python 3.12: python/cpython#102476 Switch to pathlib.Path.parts which is a tuple. Closes #1934
Small description
It appears that the
pathlib
wrapper seems to use some internals ofPath
, which will change in Python 312, and causes a failure of the test.Expected result
Tests pass.
Actual result with screenshot
Additional context
VisiData 2.11 and Python 3.12 b3
See full log here: https://koji.fedoraproject.org/koji/taskinfo?taskID=102609485
The text was updated successfully, but these errors were encountered: