Fix fingerprint dialog called twice #1100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calling event.stopPropagation() worked neither on the SettingsToggle nor on the AppSettingsItem component
andywer
reviewed
Jun 16, 2020
| @@ -64,7 +64,7 @@ export const BiometricLockSetting = React.memo(function BiometricLockSetting(pro | |||
| return ( | |||
| <AppSettingsItem | |||
| actions={ | |||
| <SettingsToggle checked={props.enrolled && props.value} disabled={!props.enrolled} onChange={props.onToggle} /> | |||
| <SettingsToggle checked={props.enrolled && props.value} disabled={!props.enrolled} onChange={() => undefined} /> | |||
There was a problem hiding this comment.
Let's add a comment here why we set a do-nothing click handler here. LGTM afterwards 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only use
props.onToggleasonClickhandler for the whole item instead of using it for item and<SettingsToggle>. Otherwise it would be called twice when the toggle is clicked.(
onChangeis a required prop of<SettingsToggle>so() => undefinedis passed instead)Reject the bio-auth test with a
CustomErrorto prevent an uncaught promise being thrown bygetErrorTranslation().Closes #1077.