Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inconsistent labelling of orders containing XLM #1092

Merged
merged 2 commits into from
Jun 8, 2020

Conversation

ebma
Copy link
Member

@ebma ebma commented May 25, 2020

Fixes inconsistencies regarding descriptions and titles of orders that contain XLM as selling asset.
While we use 'Buy xxx for XLM' as order description when an open order contains XLM as 'selling' asset the description of a canceled order and the order details did not adhere to this pattern.

  • Show 'Buy order' instead of 'Sell order' as title when clicking on an open order with XLM as selling asset
  • Remove unnecessary early return in OfferDescription and reuse existing text text for canceled orders (don't show amount if it's equal to 0 because this is our criteria for canceled orders)
  • Change alignment of 'Buy'/'Sell' summary details fields when XLM is selling asset (i.e. put 'Buy' before 'Sell' when selling XLM)

@andywer andywer merged commit 658f000 into master Jun 8, 2020
@andywer andywer deleted the bugfix/align-text-for-open-xlm-order branch June 8, 2020 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants