Fix inconsistent labelling of orders containing XLM #1092
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes inconsistencies regarding descriptions and titles of orders that contain XLM as selling asset.
While we use 'Buy xxx for XLM' as order description when an open order contains XLM as 'selling' asset the description of a canceled order and the order details did not adhere to this pattern.
OfferDescription
and reuse existing text text for canceled orders (don't show amount if it's equal to 0 because this is our criteria for canceled orders)