update to libsass beta version #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| def optional_arguments(path, optional = "bar") | ||
| Script::String.new("#{path.value}/#{optional}", :string) | ||
| def optional_arguments(path, optional = nil) | ||
| optional ||= Script::String.new("bar") |
There was a problem hiding this comment.
@edward this was the only functionality that really changed. I believe for optional values we should be specifying them as script/value objects. Might be breaking change for you?
There was a problem hiding this comment.
@bolandrm that is an excellent question. I’ll test it out on Monday and follow up.
CC @rafaelfranca since you should know about this stuff too.
bolandrm
force-pushed
the
new_libsas_version
branch
from
e391492
to
5758be7
Compare
|
Doing a beta release so we can test this a bit. |
bolandrm
added a commit
that referenced
this pull request
Oct 14, 2015
update to libsass beta version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't plan to merge until the official 3.3.0 release.