This repository has been archived by the owner on Jul 24, 2024. It is now read-only.
Set User-Agent: HTTP header #836
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. But what is the real significance of adding UA header in node-sass binary download case? |
|
It is always good to have it; I noticed we don't have one when I was testing proxy settings and #775 change - http-server just shows "undefined". I am sure corporate local mirrors would really have a proper User-Agent set for their logs. |
|
Thanks. 👍 (having a reason for change is good for future reference 😉) |
|
I agree this is useful. Scheduled it for 3.0.0. |
| @@ -25,6 +25,13 @@ function download(url, dest, cb) { | |||
| cb(typeof err.message === 'string' ? err.message : err); | |||
| }; | |||
|
|
|||
| var package = require('../package.json'); | |||
There was a problem hiding this comment.
Please move this to the top with the rest of the requires
|
Can you please rebase this off master? It's conflicting with recent updates. |
|
Superseded by #907 |
jiongle1
pushed a commit
to scantist-ossops-m2/node-sass
that referenced
this pull request
Apr 7, 2024
Don't crash with encountering a css comment in a function definition
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.