Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

Build: Centralises binary naming conventions (build changes part 2) #743

Merged
merged 4 commits into from
Mar 11, 2015

Conversation

am11
Copy link
Contributor

@am11 am11 commented Mar 7, 2015

  • Delivers binary name, paths and download URL
    from lib/extensions.js.
  • Allows user to set binary name as environment
    variable with SASS_BINARY_NAME.
    • Note: this will supersede default name.
  • Allows user to set binary name as in package
    file "nodeSassConfig": { "binary-name": "" }.
    • Note: this will supersede default name and
      SASS_BINARY_NAME environment variable.
  • Allows user to set binary name as parameter to
    invoke any node-sass script with
    --binary-name flag.
    • Note: this will supersede default name, name
      defined in package nodeSassConfig as well
      as the SASS_BINARY_NAME environment
      variable.
  • This binary name will be used to construct the:
    • Binary path.
    • Binary download URL.
    • Upload URL.
  • Allows user to set binary path as environment
    variable with SASS_BINARY_PATH.
    • Note: this will supersede default path.
  • Allows user to set binary name as in package
    file "nodeSassConfig": { "binary-path": "" }.
    • Note: this will supersede default path and
      SASS_BINARY_PATH environment variable.
  • Allows user to set binary path as parameter to
    invoke any node-sass script with
    --binary-path flag.
    • Note: this will supersede default path, path
      as well as the SASS_BINARY_PATH environment
      variable.
  • This binary path will be used when:
    • Requiring node-sass package.
    • Downloading binary.
    • Uploading binary.
  • Wraps all extensions in process.sass
    namespace.

Issue URL: #712.

//cc @nschonni, @xzyfer

am11 added a commit to am11/node-sass that referenced this pull request Mar 7, 2015
  from lib/extensions.js.
* Allows user to set binary name as environment
  variable with `SASS_BINARY_NAME`.
  * This name will be used to construct the:
    * Binary path.
    * Binary download URL.
    * Upload URL.
  * Note: this will supersede default name.
* Allows user to set binary name as parameter to
  invoke any node-sass script with
  `--binary-name` flag.
  * This name will be used to construct the:
    * Binary path.
    * Binary download URL.
    * Upload URL.
  * Note: this will supersede both default name
    as well as the `SASS_BINARY_NAME` environment
    variable.
* Allows user to set binary path as environment
  variable with `SASS_BINARY_PATH`.
  * This name will be used when:
    * Requiring node-sass package.
    * Downloading binary.
    * Uploading binary.
  * Note: this will supersede default path.
* Allows user to set binary path as parameter to
  invoke any node-sass script with
  `--binary-path` flag.
  * This name will be used when:
    * Requiring node-sass package.
    * Downloading binary.
    * Uploading binary.
  * Note: this will supersede both default path
    as well as the `SASS_BINARY_PATH` environment
    variable.
* Wraps all extensions in `process.sass`
  namespace.

Issue URL: sass#712.
PR URL: sass#743.

//cc @nschonni, @xzyfer
am11 added a commit to am11/node-sass that referenced this pull request Mar 7, 2015
  from lib/extensions.js.
* Allows user to set binary name as environment
  variable with `SASS_BINARY_NAME`.
  * This name will be used to construct the:
    * Binary path.
    * Binary download URL.
    * Upload URL.
  * Note: this will supersede default name.
* Allows user to set binary name as parameter to
  invoke any node-sass script with
  `--binary-name` flag.
  * This name will be used to construct the:
    * Binary path.
    * Binary download URL.
    * Upload URL.
  * Note: this will supersede both default name
    as well as the `SASS_BINARY_NAME` environment
    variable.
* Allows user to set binary path as environment
  variable with `SASS_BINARY_PATH`.
  * This name will be used when:
    * Requiring node-sass package.
    * Downloading binary.
    * Uploading binary.
  * Note: this will supersede default path.
* Allows user to set binary path as parameter to
  invoke any node-sass script with
  `--binary-path` flag.
  * This name will be used when:
    * Requiring node-sass package.
    * Downloading binary.
    * Uploading binary.
  * Note: this will supersede both default path
    as well as the `SASS_BINARY_PATH` environment
    variable.
* Wraps all extensions in `process.sass`
  namespace.

Issue URL: sass#712.
PR URL: sass#743.

//cc @nschonni, @xzyfer
am11 added a commit to am11/node-sass that referenced this pull request Mar 7, 2015
* Delivers binary name, paths and download URL
  from lib/extensions.js.
* Allows user to set binary name as environment
  variable with `SASS_BINARY_NAME`.
  * This name will be used to construct the:
    * Binary path.
    * Binary download URL.
    * Upload URL.
  * Note: this will supersede default name.
* Allows user to set binary name as parameter to
  invoke any node-sass script with
  `--binary-name` flag.
  * This name will be used to construct the:
    * Binary path.
    * Binary download URL.
    * Upload URL.
  * Note: this will supersede both default name
    as well as the `SASS_BINARY_NAME` environment
    variable.
* Allows user to set binary path as environment
  variable with `SASS_BINARY_PATH`.
  * This name will be used when:
    * Requiring node-sass package.
    * Downloading binary.
    * Uploading binary.
  * Note: this will supersede default path.
* Allows user to set binary path as parameter to
  invoke any node-sass script with
  `--binary-path` flag.
  * This name will be used when:
    * Requiring node-sass package.
    * Downloading binary.
    * Uploading binary.
  * Note: this will supersede both default path
    as well as the `SASS_BINARY_PATH` environment
    variable.
* Wraps all extensions in `process.sass`
  namespace.

Issue URL: sass#712.
PR URL: sass#743.

//cc @nschonni, @xzyfer
am11 added a commit to am11/node-sass that referenced this pull request Mar 7, 2015
* Delivers binary name, paths and download URL
  from lib/extensions.js.
* Allows user to set binary name as environment
  variable with `SASS_BINARY_NAME`.
  * This name will be used to construct the:
    * Binary path.
    * Binary download URL.
    * Upload URL.
  * Note: this will supersede default name.
* Allows user to set binary name as parameter to
  invoke any node-sass script with
  `--binary-name` flag.
  * This name will be used to construct the:
    * Binary path.
    * Binary download URL.
    * Upload URL.
  * Note: this will supersede both default name
    as well as the `SASS_BINARY_NAME` environment
    variable.
* Allows user to set binary path as environment
  variable with `SASS_BINARY_PATH`.
  * This name will be used when:
    * Requiring node-sass package.
    * Downloading binary.
    * Uploading binary.
  * Note: this will supersede default path.
* Allows user to set binary path as parameter to
  invoke any node-sass script with
  `--binary-path` flag.
  * This name will be used when:
    * Requiring node-sass package.
    * Downloading binary.
    * Uploading binary.
  * Note: this will supersede both default path
    as well as the `SASS_BINARY_PATH` environment
    variable.
* Wraps all extensions in `process.sass`
  namespace.

Issue URL: sass#712.
PR URL: sass#743.
@am11 am11 force-pushed the improve-build branch 5 times, most recently from 0590d3d to 869827d Compare March 8, 2015 11:42
am11 added a commit to am11/node-sass that referenced this pull request Mar 8, 2015
* Delivers binary name, paths and download URL
  from lib/extensions.js.
* Allows user to set binary name as environment
  variable with `SASS_BINARY_NAME`.
  * This name will be used to construct the:
    * Binary path.
    * Binary download URL.
    * Upload URL.
  * Note: this will supersede default name.
* Allows user to set binary name as parameter to
  invoke any node-sass script with
  `--binary-name` flag.
  * This name will be used to construct the:
    * Binary path.
    * Binary download URL.
    * Upload URL.
  * Note: this will supersede both default name
    as well as the `SASS_BINARY_NAME` environment
    variable.
* Allows user to set binary path as environment
  variable with `SASS_BINARY_PATH`.
  * This name will be used when:
    * Requiring node-sass package.
    * Downloading binary.
    * Uploading binary.
  * Note: this will supersede default path.
* Allows user to set binary path as parameter to
  invoke any node-sass script with
  `--binary-path` flag.
  * This name will be used when:
    * Requiring node-sass package.
    * Downloading binary.
    * Uploading binary.
  * Note: this will supersede both default path
    as well as the `SASS_BINARY_PATH` environment
    variable.
* Wraps all extensions in `process.sass`
  namespace.

Issue URL: sass#712.
PR URL: sass#743.
am11 added a commit to am11/node-sass that referenced this pull request Mar 8, 2015
* Delivers binary name, paths and download URL
  from lib/extensions.js.
* Allows user to set binary name as environment
  variable with `SASS_BINARY_NAME`.
  * This name will be used to construct the:
    * Binary path.
    * Binary download URL.
    * Upload URL.
  * Note: this will supersede default name.
* Allows user to set binary name as parameter to
  invoke any node-sass script with
  `--binary-name` flag.
  * This name will be used to construct the:
    * Binary path.
    * Binary download URL.
    * Upload URL.
  * Note: this will supersede both default name
    as well as the `SASS_BINARY_NAME` environment
    variable.
* Allows user to set binary path as environment
  variable with `SASS_BINARY_PATH`.
  * This name will be used when:
    * Requiring node-sass package.
    * Downloading binary.
    * Uploading binary.
  * Note: this will supersede default path.
* Allows user to set binary path as parameter to
  invoke any node-sass script with
  `--binary-path` flag.
  * This name will be used when:
    * Requiring node-sass package.
    * Downloading binary.
    * Uploading binary.
  * Note: this will supersede both default path
    as well as the `SASS_BINARY_PATH` environment
    variable.
* Wraps all extensions in `process.sass`
  namespace.

Issue URL: sass#712.
PR URL: sass#743.
am11 added a commit to am11/node-sass that referenced this pull request Mar 8, 2015
* Delivers binary name, paths and download URL
  from lib/extensions.js.
* Allows user to set binary name as environment
  variable with `SASS_BINARY_NAME`.
  * This name will be used to construct the:
    * Binary path.
    * Binary download URL.
    * Upload URL.
  * Note: this will supersede default name.
* Allows user to set binary name as parameter to
  invoke any node-sass script with
  `--binary-name` flag.
  * This name will be used to construct the:
    * Binary path.
    * Binary download URL.
    * Upload URL.
  * Note: this will supersede both default name
    as well as the `SASS_BINARY_NAME` environment
    variable.
* Allows user to set binary path as environment
  variable with `SASS_BINARY_PATH`.
  * This name will be used when:
    * Requiring node-sass package.
    * Downloading binary.
    * Uploading binary.
  * Note: this will supersede default path.
* Allows user to set binary path as parameter to
  invoke any node-sass script with
  `--binary-path` flag.
  * This name will be used when:
    * Requiring node-sass package.
    * Downloading binary.
    * Uploading binary.
  * Note: this will supersede both default path
    as well as the `SASS_BINARY_PATH` environment
    variable.
* Wraps all extensions in `process.sass`
  namespace.

Issue URL: sass#712.
PR URL: sass#743.
am11 added a commit to am11/node-sass that referenced this pull request Mar 8, 2015
* Delivers binary name, paths and download URL
  from lib/extensions.js.
* Allows user to set binary name as environment
  variable with `SASS_BINARY_NAME`.
  * This name will be used to construct the:
    * Binary path.
    * Binary download URL.
    * Upload URL.
  * Note: this will supersede default name.
* Allows user to set binary name as parameter to
  invoke any node-sass script with
  `--binary-name` flag.
  * This name will be used to construct the:
    * Binary path.
    * Binary download URL.
    * Upload URL.
  * Note: this will supersede both default name
    as well as the `SASS_BINARY_NAME` environment
    variable.
* Allows user to set binary path as environment
  variable with `SASS_BINARY_PATH`.
  * This name will be used when:
    * Requiring node-sass package.
    * Downloading binary.
    * Uploading binary.
  * Note: this will supersede default path.
* Allows user to set binary path as parameter to
  invoke any node-sass script with
  `--binary-path` flag.
  * This name will be used when:
    * Requiring node-sass package.
    * Downloading binary.
    * Uploading binary.
  * Note: this will supersede both default path
    as well as the `SASS_BINARY_PATH` environment
    variable.
* Wraps all extensions in `process.sass`
  namespace.

Issue URL: sass#712.
PR URL: sass#743.
am11 added a commit to am11/node-sass that referenced this pull request Mar 8, 2015
* Delivers binary name, paths and download URL
  from lib/extensions.js.
* Allows user to set binary name as environment
  variable with `SASS_BINARY_NAME`.
  * This name will be used to construct the:
    * Binary path.
    * Binary download URL.
    * Upload URL.
  * Note: this will supersede default name.
* Allows user to set binary name as parameter to
  invoke any node-sass script with
  `--binary-name` flag.
  * This name will be used to construct the:
    * Binary path.
    * Binary download URL.
    * Upload URL.
  * Note: this will supersede both default name
    as well as the `SASS_BINARY_NAME` environment
    variable.
* Allows user to set binary path as environment
  variable with `SASS_BINARY_PATH`.
  * This name will be used when:
    * Requiring node-sass package.
    * Downloading binary.
    * Uploading binary.
  * Note: this will supersede default path.
* Allows user to set binary path as parameter to
  invoke any node-sass script with
  `--binary-path` flag.
  * This name will be used when:
    * Requiring node-sass package.
    * Downloading binary.
    * Uploading binary.
  * Note: this will supersede both default path
    as well as the `SASS_BINARY_PATH` environment
    variable.
* Wraps all extensions in `process.sass`
  namespace.

Issue URL: sass#712.
PR URL: sass#743.
am11 added a commit to am11/node-sass that referenced this pull request Mar 8, 2015
* Delivers binary name, paths and download URL
  from lib/extensions.js.
* Allows user to set binary name as environment
  variable with `SASS_BINARY_NAME`.
  * This name will be used to construct the:
    * Binary path.
    * Binary download URL.
    * Upload URL.
  * Note: this will supersede default name.
* Allows user to set binary name as parameter to
  invoke any node-sass script with
  `--binary-name` flag.
  * This name will be used to construct the:
    * Binary path.
    * Binary download URL.
    * Upload URL.
  * Note: this will supersede both default name
    as well as the `SASS_BINARY_NAME` environment
    variable.
* Allows user to set binary path as environment
  variable with `SASS_BINARY_PATH`.
  * This name will be used when:
    * Requiring node-sass package.
    * Downloading binary.
    * Uploading binary.
  * Note: this will supersede default path.
* Allows user to set binary path as parameter to
  invoke any node-sass script with
  `--binary-path` flag.
  * This name will be used when:
    * Requiring node-sass package.
    * Downloading binary.
    * Uploading binary.
  * Note: this will supersede both default path
    as well as the `SASS_BINARY_PATH` environment
    variable.
* Wraps all extensions in `process.sass`
  namespace.

Issue URL: sass#712.
PR URL: sass#743.
am11 added a commit to am11/node-sass that referenced this pull request Mar 8, 2015
* Delivers binary name, paths and download URL
  from lib/extensions.js.
* Allows user to set binary name as environment
  variable with `SASS_BINARY_NAME`.
  * This name will be used to construct the:
    * Binary path.
    * Binary download URL.
    * Upload URL.
  * Note: this will supersede default name.
* Allows user to set binary name as parameter to
  invoke any node-sass script with
  `--binary-name` flag.
  * This name will be used to construct the:
    * Binary path.
    * Binary download URL.
    * Upload URL.
  * Note: this will supersede both default name
    as well as the `SASS_BINARY_NAME` environment
    variable.
* Allows user to set binary path as environment
  variable with `SASS_BINARY_PATH`.
  * This name will be used when:
    * Requiring node-sass package.
    * Downloading binary.
    * Uploading binary.
  * Note: this will supersede default path.
* Allows user to set binary path as parameter to
  invoke any node-sass script with
  `--binary-path` flag.
  * This name will be used when:
    * Requiring node-sass package.
    * Downloading binary.
    * Uploading binary.
  * Note: this will supersede both default path
    as well as the `SASS_BINARY_PATH` environment
    variable.
* Wraps all extensions in `process.sass`
  namespace.

Issue URL: sass#712.
PR URL: sass#743.
am11 added a commit to am11/node-sass that referenced this pull request Mar 9, 2015
am11 added a commit to am11/node-sass that referenced this pull request Mar 9, 2015
* Delivers binary name, paths and download URL
  from lib/extensions.js.
* Allows user to set binary name as environment
  variable with `SASS_BINARY_NAME`.
  * This name will be used to construct the:
    * Binary path.
    * Binary download URL.
    * Upload URL.
  * Note: this will supersede default name.
* Allows user to set binary name as parameter to
  invoke any node-sass script with
  `--binary-name` flag.
  * This name will be used to construct the:
    * Binary path.
    * Binary download URL.
    * Upload URL.
  * Note: this will supersede both default name
    as well as the `SASS_BINARY_NAME` environment
    variable.
* Allows user to set binary path as environment
  variable with `SASS_BINARY_PATH`.
  * This name will be used when:
    * Requiring node-sass package.
    * Downloading binary.
    * Uploading binary.
  * Note: this will supersede default path.
* Allows user to set binary path as parameter to
  invoke any node-sass script with
  `--binary-path` flag.
  * This name will be used when:
    * Requiring node-sass package.
    * Downloading binary.
    * Uploading binary.
  * Note: this will supersede both default path
    as well as the `SASS_BINARY_PATH` environment
    variable.
* Wraps all extensions in `process.sass`
  namespace.

Issue URL: sass#712.
PR URL: sass#743.
am11 added a commit to am11/node-sass that referenced this pull request Mar 9, 2015
am11 added a commit to am11/node-sass that referenced this pull request Mar 9, 2015
* Delivers binary name, paths and download URL
  from lib/extensions.js.

* Allows user to set binary name as environment
  variable with `SASS_BINARY_NAME`.
  * Note: this will supersede default name.
* Allows user to set binary name as in package
  file `"nodeSassConfig": { "binary-name": "" }`.
  * Note: this will supersede default name and
    `SASS_BINARY_NAME` environment variable.
* Allows user to set binary name as parameter to
  invoke any node-sass script with
  `--binary-name` flag.
  * Note: this will supersede default name, name
    defined in package `nodeSassConfig` as well
    as the `SASS_BINARY_NAME` environment
    variable.

* This binary name will be used to construct the:
  * Binary path.
  * Binary download URL.
  * Upload URL.

* Allows user to set binary path as environment
  variable with `SASS_BINARY_PATH`.
  * Note: this will supersede default path.
* Allows user to set binary name as in package
  file `"nodeSassConfig": { "binary-path": "" }`.
  * Note: this will supersede default path and
    `SASS_BINARY_PATH` environment variable.
* Allows user to set binary path as parameter to
  invoke any node-sass script with
  `--binary-path` flag.
  * Note: this will supersede default path, path
    as well as the `SASS_BINARY_PATH` environment
    variable.

* This binary path will be used when:
  * Requiring node-sass package.
  * Downloading binary.
  * Uploading binary.

* Wraps all extensions in `process.sass`
  namespace.

Issue URL: sass#712.
PR URL: sass#743.
am11 added a commit to am11/node-sass that referenced this pull request Mar 9, 2015
@am11 am11 changed the title Build: Centralises binary naming convensions (build changes part 2) Build: Centralises binary naming conventions (build changes part 2) Mar 9, 2015
@am11
Copy link
Contributor Author

am11 commented Mar 9, 2015

@nschonni, I have added the support for nodeSassConfig.binaryName and nodeSassConfig.binaryPath.

PTAL.

am11 added a commit to am11/node-sass that referenced this pull request Mar 10, 2015
* Delivers binary name, paths and download URL
  from lib/extensions.js.

* Allows user to set binary name as environment
  variable with `SASS_BINARY_NAME`.
  * Note: this will supersede default name.
* Allows user to set binary name as in package
  file `"nodeSassConfig": { "binary-name": "" }`.
  * Note: this will supersede default name and
    `SASS_BINARY_NAME` environment variable.
* Allows user to set binary name as parameter to
  invoke any node-sass script with
  `--binary-name` flag.
  * Note: this will supersede default name, name
    defined in package `nodeSassConfig` as well
    as the `SASS_BINARY_NAME` environment
    variable.

* This binary name will be used to construct the:
  * Binary path.
  * Binary download URL.
  * Upload URL.

* Allows user to set binary path as environment
  variable with `SASS_BINARY_PATH`.
  * Note: this will supersede default path.
* Allows user to set binary name as in package
  file `"nodeSassConfig": { "binary-path": "" }`.
  * Note: this will supersede default path and
    `SASS_BINARY_PATH` environment variable.
* Allows user to set binary path as parameter to
  invoke any node-sass script with
  `--binary-path` flag.
  * Note: this will supersede default path, path
    as well as the `SASS_BINARY_PATH` environment
    variable.

* This binary path will be used when:
  * Requiring node-sass package.
  * Downloading binary.
  * Uploading binary.

* Wraps all extensions in `process.sass`
  namespace.

Issue URL: sass#712.
PR URL: sass#743.
am11 added a commit to am11/node-sass that referenced this pull request Mar 10, 2015
* Delivers binary name, paths and download URL
  from lib/extensions.js.

* Allows user to set binary name as environment
  variable with `SASS_BINARY_NAME`.
  * Note: this will supersede default name.
* Allows user to set binary name as in package
  file `"nodeSassConfig": { "binary-name": "" }`.
  * Note: this will supersede default name and
    `SASS_BINARY_NAME` environment variable.
* Allows user to set binary name as parameter to
  invoke any node-sass script with
  `--binary-name` flag.
  * Note: this will supersede default name, name
    defined in package `nodeSassConfig` as well
    as the `SASS_BINARY_NAME` environment
    variable.

* This binary name will be used to construct the:
  * Binary path.
  * Binary download URL.
  * Upload URL.

* Allows user to set binary path as environment
  variable with `SASS_BINARY_PATH`.
  * Note: this will supersede default path.
* Allows user to set binary name as in package
  file `"nodeSassConfig": { "binary-path": "" }`.
  * Note: this will supersede default path and
    `SASS_BINARY_PATH` environment variable.
* Allows user to set binary path as parameter to
  invoke any node-sass script with
  `--binary-path` flag.
  * Note: this will supersede default path, path
    as well as the `SASS_BINARY_PATH` environment
    variable.

* This binary path will be used when:
  * Requiring node-sass package.
  * Downloading binary.
  * Uploading binary.

* Wraps all extensions in `process.sass`
  namespace.

Issue URL: sass#712.
PR URL: sass#743.
am11 added a commit that referenced this pull request Mar 11, 2015
Build: Centralises binary naming conventions (build changes part 2)
@am11 am11 merged commit 89f5290 into sass:master Mar 11, 2015
@am11 am11 deleted the improve-build branch March 11, 2015 00:22
am11 added a commit to am11/node-sass that referenced this pull request Mar 11, 2015
* Delivers binary name, paths and download URL
  from lib/extensions.js.

* Allows user to set binary name as environment
  variable with `SASS_BINARY_NAME`.
  * Note: this will supersede default name.
* Allows user to set binary name as in package
  file `"nodeSassConfig": { "binary-name": "" }`.
  * Note: this will supersede default name and
    `SASS_BINARY_NAME` environment variable.
* Allows user to set binary name as parameter to
  invoke any node-sass script with
  `--binary-name` flag.
  * Note: this will supersede default name, name
    defined in package `nodeSassConfig` as well
    as the `SASS_BINARY_NAME` environment
    variable.

* This binary name will be used to construct the:
  * Binary path.
  * Binary download URL.
  * Upload URL.

* Allows user to set binary path as environment
  variable with `SASS_BINARY_PATH`.
  * Note: this will supersede default path.
* Allows user to set binary name as in package
  file `"nodeSassConfig": { "binary-path": "" }`.
  * Note: this will supersede default path and
    `SASS_BINARY_PATH` environment variable.
* Allows user to set binary path as parameter to
  invoke any node-sass script with
  `--binary-path` flag.
  * Note: this will supersede default path, path
    as well as the `SASS_BINARY_PATH` environment
    variable.

* This binary path will be used when:
  * Requiring node-sass package.
  * Downloading binary.
  * Uploading binary.

* Wraps all extensions in `process.sass`
  namespace.

Issue URL: sass#712.
PR URL: sass#743.
am11 added a commit to am11/node-sass that referenced this pull request Mar 11, 2015
am11 added a commit to am11/node-sass that referenced this pull request Mar 11, 2015
@am11 am11 mentioned this pull request May 2, 2015
jiongle1 pushed a commit to scantist-ossops-m2/node-sass that referenced this pull request Apr 7, 2024
Better support for parsing complex ie function values
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants