Watcher should track newly created files #1896
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xzyfer
force-pushed
the
watcher-added
branch
4 times, most recently
from
68d52b3
to
b12002a
Compare
|
I've digging into the watcher tests. I don't think I've addressed all the flakiness but I'm confident I can now address the flaky specs as we notice them. I've reenabled them as part of this PR. |
xzyfer
force-pushed
the
watcher-added
branch
from
b12002a
to
9429c88
Compare
xzyfer
force-pushed
the
watcher-added
branch
from
9429c88
to
dd5cd52
Compare
|
Some watcher tests still appear to be flakey. I've done a little more hardening. I'll re-disable any particularly troublesome specs until I have a better solution. Keen to get this out soon. |
xzyfer
force-pushed
the
watcher-added
branch
6 times, most recently
from
a4ddbdb
to
731a73c
Compare
|
Thanks! Sorry that getting it through seems frustrating 😞 Hope you’ll figure it out! |
|
Is there anything here that community could help you with? |
|
Sorry, I bit off more than I could chew with my time. I'll double check
this works and ship it.
…On 28 Mar. 2017 7:14 pm, "Dan Abramov" ***@***.***> wrote:
Is there anything here that community could help you with?
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<#1896 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAjZWFlQQrjVKk1pcBuc_Xm9oRkipcT8ks5rqMFvgaJpZM4L-0G->
.
|
xzyfer
force-pushed
the
watcher-added
branch
12 times, most recently
from
3e19b54
to
bdde742
Compare
|
I think I'm really close on this now. Should hopefully land this weekend. |
Currently newly created are added to the graph but not added the watcher. Fixes sass#1891
These have been notoriously flakey so they were disabled a long ago.
xzyfer
added a commit
to xzyfer/node-sass
that referenced
this pull request
Jun 15, 2017
This logic is all tightly coupled in the bin. This logic has been notoriously impossible to test due to weird fs timing issues. By extracting the actual logic we're now able to test it in isolation. With this in place replacing Gaze (sass#636) becomes a viable option. Closes sass#1896 Fixes sass#1891
xzyfer
added a commit
to xzyfer/node-sass
that referenced
this pull request
Jun 15, 2017
This logic is all tightly coupled in the bin. This logic has been notoriously impossible to test due to weird fs timing issues. By extracting the actual logic we're now able to test it in isolation. With this in place replacing Gaze (sass#636) becomes a viable option. This PR not only massively increases our test coverage for the watcher but also address a bunch of known edge cases i.e. orphaned imports when a files is deleted. Closes sass#1896 Fixes sass#1891
xzyfer
added a commit
to xzyfer/node-sass
that referenced
this pull request
Jun 15, 2017
This logic is all tightly coupled in the bin. This logic has been notoriously impossible to test due to weird fs timing issues. By extracting the actual logic we're now able to test it in isolation. With this in place replacing Gaze (sass#636) becomes a viable option. This PR not only massively increases our test coverage for the watcher but also address a bunch of known edge cases i.e. orphaned imports when a files is deleted. Closes sass#1896 Fixes sass#1891
xzyfer
added a commit
to xzyfer/node-sass
that referenced
this pull request
Jun 15, 2017
This logic is all tightly coupled in the bin. This logic has been notoriously impossible to test due to weird fs timing issues. By extracting the actual logic we're now able to test it in isolation. With this in place replacing Gaze (sass#636) becomes a viable option. This PR not only massively increases our test coverage for the watcher but also address a bunch of known edge cases i.e. orphaned imports when a files is deleted. Closes sass#1896 Fixes sass#1891
xzyfer
added a commit
to xzyfer/node-sass
that referenced
this pull request
Jun 15, 2017
This logic is all tightly coupled in the bin. This logic has been notoriously impossible to test due to weird fs timing issues. By extracting the actual logic we're now able to test it in isolation. With this in place replacing Gaze (sass#636) becomes a viable option. This PR not only massively increases our test coverage for the watcher but also address a bunch of known edge cases i.e. orphaned imports when a files is deleted. Closes sass#1896 Fixes sass#1891
|
Tacking this in #2020. Should land any day now. |
xzyfer
added a commit
that referenced
this pull request
Jun 17, 2017
This logic is all tightly coupled in the bin. This logic has been notoriously impossible to test due to weird fs timing issues. By extracting the actual logic we're now able to test it in isolation. With this in place replacing Gaze (#636) becomes a viable option. This PR not only massively increases our test coverage for the watcher but also address a bunch of known edge cases i.e. orphaned imports when a files is deleted. Closes #1896 Fixes #1891
Friendly-users
referenced
this pull request
in Friendly-users/node-sass
Jul 9, 2024
----- It is inappropriate to include political and offensive content in public code repositories. Public code repositories should be neutral spaces for collaboration and community, free from personal or political views that could alienate or discriminate against others. Political content, especially that which targets or disparages minority groups, can be harmful and divisive. It can make people feel unwelcome and unsafe, and it can create a hostile work environment. Please refrain from adding such content to public code repositories.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently newly created are added to the graph but not added the
watcher.
Fixes #1891