This repository has been archived by the owner on Jul 24, 2024. It is now read-only.
Node 6 for Windows: Don't use subst for testing #1514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Did you miss the non-release config? |
|
Of course I have. Thanks! |
Node 6.x has trouble including modules from MS-DOS drives created with subst.exe. Since we use use subst only to set symbols paths in the PDB file, let's revert to the C: drive when doing tests. Workaround for: nodejs/node#6500
|
👯 |
saper
changed the title
|
Thank you kindly 🎉 |
xzyfer
added a commit
that referenced
this pull request
Jun 7, 2016
This reverts commit 15fe42e to assert nodejs/node#6500 is resolved in Node v6.2.0.
xzyfer
added a commit
that referenced
this pull request
Jun 7, 2016
This reverts commit 15fe42e to assert nodejs/node#6500 is resolved in Node v6.2.0.
xzyfer
added a commit
that referenced
this pull request
Jun 7, 2016
This reverts commit 15fe42e to assert nodejs/node#6500 is resolved in Node v6.2.0.
xzyfer
added a commit
to xzyfer/node-sass
that referenced
this pull request
Dec 10, 2016
This was originally removed in sass#1514 to work around nodejs/node#6500 which has since been resolved. This isn't playing nice with our npm cache in CI because we're changing the current path after running npm install.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node 6.x has trouble probably including
modules from the substed drivers.
Since we use use subst only to set
symbols paths in the PDB file, let's
revert to the C: drive when doing tests.
Workaround for: nodejs/node#6500