Skip to content
This repository has been archived by the owner on May 28, 2018. It is now read-only.

Linux ARM: Add binaries for 2.0.1 #42

Closed
wants to merge 2 commits into from
Closed

Conversation

gjungb
Copy link

@gjungb gjungb commented Feb 20, 2015

I'm preparing a Raspberry Pi CI 'cluster' and as such am in need of running node-sass via gulp or grunt during the build process. Compilation via node-gyp rebuild on a Raspberry Pi 2 Model B went smoothly. So here comes the binary.

The results of npm test look mostly good:

672 passing (34s)
  3 failing

  1) cli node-sass in.scss should emit `warn` on file change when using --watch option:
     Error: timeout of 2000ms exceeded
      at null.<anonymous> (/home/pi/node-sass/node_modules/mocha/lib/runnable.js:159:19)
      at Timer.listOnTimeout [as ontimeout] (timers.js:112:15)

  2) cli node-sass in.scss should render all watched files:
     Error: timeout of 2000ms exceeded
      at null.<anonymous> (/home/pi/node-sass/node_modules/mocha/lib/runnable.js:159:19)
      at Timer.listOnTimeout [as ontimeout] (timers.js:112:15)

  3) spec scss huge:
     Error: timeout of 2000ms exceeded
      at null.<anonymous> (/home/pi/node-sass/node_modules/mocha/lib/runnable.js:159:19)
      at Timer.listOnTimeout [as ontimeout] (timers.js:112:15)

@am11
Copy link
Contributor

am11 commented Feb 20, 2015

Thanks for your contribution.

You can ignore the failing tests because they are timeout issues, mostly the inconsistent behaviour of mocha, libuv or both. If you try again, it may fail none or different tests with timeout message.

Our binary distribution works per version basis. The released tag of node-sass-binaries should match with that and version of node-sass. At this point v2.0.1 is already published, so the user will not be able to download it with npm install. We can, however, consider adding binary for vNext, which -- when appear -- will have latest version of libsass and changes in our binding code.

In future, please consider adding binaries for node v0.10, v0.12 and io.js v0.12. That is; latest stable and one previous version of node and latest version of io.js. See the coverage matrix: sass/node-sass#655.

@am11
Copy link
Contributor

am11 commented Feb 27, 2015

@gjungb, we do not commit anything node-sass-binaries repos unless its time for a next release.

Thanks again for contributing, but it is not the time for vNext yet and we might abandon the node-sass-binaries in favour of sass/node-sass#712.

@xzyfer
Copy link
Contributor

xzyfer commented May 13, 2015

This is no longer applicable. Please regenerate binaries against 3.1.0 if you still wish to contribute these binaries.

@xzyfer xzyfer closed this May 13, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants