Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken link #2105

Merged
merged 2 commits into from
Jun 14, 2016
Merged

Fix broken link #2105

merged 2 commits into from
Jun 14, 2016

Conversation

MoritzKn
Copy link
Contributor

No description provided.

@coveralls
Copy link

coveralls commented Jun 13, 2016

Coverage Status

Coverage remained the same at 79.083% when pulling a2e057f on MoritzKn:patch-1 into 4acbae7 on sass:master.

@MoritzKn MoritzKn changed the title Fixed broken link Fix broken link Jun 13, 2016
@@ -88,5 +88,5 @@ Our MIT license is designed to be as simple, and liberal as possible.
[@mgreter]: https://github.com/mgreter
[@xzyfer]: https://github.com/xzyfer

sass2scss was originally written by [Marcel Greter](@mgreter)
sass2scss was originally written by [Marcel Greter](https://github.com/mgreter)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The proper fix for this is to move the reference links below this line.

 [@hcatlin]: https://github.com/hcatlin
 [@akhleung]: https://github.com/akhleung
 [@chriseppstein]: https://github.com/chriseppstein
 [@nex3]: https://github.com/nex3
 [@mgreter]: https://github.com/mgreter
 [@xzyfer]: https://github.com/xzyfer

Copy link
Contributor Author

@MoritzKn MoritzKn Jun 14, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If i move the reference links to the end of the file, the link [Marcel Greater](@mgreter) still don't works. It only seems to work if i write it like this [@mgreter].

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct, the () are a typo it should be []. You may not even need to move the references.

@xzyfer
Copy link
Contributor

xzyfer commented Jun 14, 2016

Thanks @MoritzKn

@xzyfer xzyfer added this to the 3.3.7 milestone Jun 14, 2016
@coveralls
Copy link

coveralls commented Jun 14, 2016

Coverage Status

Coverage remained the same at 79.083% when pulling f093070 on MoritzKn:patch-1 into 4acbae7 on sass:master.

@xzyfer xzyfer merged commit 38fd793 into sass:master Jun 14, 2016
@xzyfer xzyfer modified the milestones: 3.3.7, 3.4 Oct 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants