Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] POC of refactor to support at-root correctly #1900

Closed
wants to merge 1 commit into from

Conversation

mgreter
Copy link
Contributor

@mgreter mgreter commented Jan 27, 2016

@xzyfer this is a very early WIP PR which currently should pass all spec tests (AFAICS minus one error spec) and fixes about ~5 currently open issues. Many unused code duplicates of failed trials need to be removed and consolidation needs to be done for quite a few aspects. This branch will act as a starting point for that work, so I'm posting it here since sharing is caring.

@xzyfer
Copy link
Contributor

xzyfer commented Mar 17, 2016

Can you please reference the issues this fixes?

For the record we currently support with/without and there test coverage. it'd be good to clear about what specifically this is aiming to fix.

@mgreter
Copy link
Contributor Author

mgreter commented Apr 15, 2016

@xzyfer we need to move the parentization to the cssize stage, since we otherwise "freeze" it too early. Extends happen after the eval stage and therefore parent references will be wrong.

@xzyfer
Copy link
Contributor

xzyfer commented May 20, 2016

I'm pretty sure this is fixed in #2089. We can look at at-root again when we have a specific known failure.

@xzyfer xzyfer closed this May 20, 2016
@xzyfer xzyfer reopened this May 21, 2016
@xzyfer
Copy link
Contributor

xzyfer commented May 21, 2016

After some further investigation there are still problem related to at-root but they stem from broken parentizing, not the at-root implementation itself. Specific issues are #2006 and #1890 both of which are incorrectly parentized before reaching CSSize.

The issue is certainly with our parentizing, so any fix should not touch the cssize visitor since it is line for line compliant with Ruby Sass.

@mgreter mgreter closed this May 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants