Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement initial selector namespace handling #1058

Closed
wants to merge 1 commit into from

Conversation

mgreter
Copy link
Contributor

@mgreter mgreter commented Apr 7, 2015

Initial implementation for selector namespaces

Makes is (atm) pass these spec tests:

  • extend-tests/021_test_universal_unification_with_simple_target
  • extend-tests/023_test_universal_unification_with_simple_target
  • extend-tests/026_test_universal_unification_with_namespaceless_universal_target
  • extend-tests/028_test_universal_unification_with_namespaceless_universal_target
  • extend-tests/031_test_universal_unification_with_namespaced_universal_target
  • extend-tests/032_test_universal_unification_with_namespaced_universal_target
  • extend-tests/033_test_universal_unification_with_namespaced_universal_target
  • extend-tests/035_test_universal_unification_with_namespaceless_element_target
  • extend-tests/037_test_universal_unification_with_namespaceless_element_target
  • extend-tests/041_test_universal_unification_with_namespaced_element_target
  • extend-tests/042_test_universal_unification_with_namespaced_element_target
  • extend-tests/049_test_element_unification_with_namespaceless_universal_target
  • extend-tests/050_test_element_unification_with_namespaceless_universal_target
  • extend-tests/052_test_element_unification_with_namespaceless_universal_target
  • extend-tests/055_test_element_unification_with_namespaced_universal_target
  • extend-tests/057_test_element_unification_with_namespaceless_element_target
  • extend-tests/062_test_element_unification_with_namespaced_element_target
  • extend-tests/063_test_element_unification_with_namespaced_element_target

Needs more work to get extend working correctly with namespaces (selector unifying)!

@mgreter mgreter self-assigned this Apr 7, 2015
@mgreter mgreter added this to the 3.2.1 milestone Apr 7, 2015
@coveralls
Copy link

Coverage Status

Coverage increased (+0.09%) to 80.65% when pulling c9ff5c9 on mgreter:feature/selector-namespace into f82a41b on sass:master.

@xzyfer xzyfer modified the milestones: 3.2.2, 3.3 May 1, 2015
@mgreter
Copy link
Contributor Author

mgreter commented Jul 13, 2015

This has been merged with #1249!

@mgreter mgreter closed this Jul 13, 2015
@mgreter mgreter deleted the feature/selector-namespace branch July 28, 2015 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants