Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix separator preserving with rest args #1050

Merged
merged 2 commits into from
May 8, 2015
Merged

Fix separator preserving with rest args #1050

merged 2 commits into from
May 8, 2015

Conversation

mgreter
Copy link
Contributor

@mgreter mgreter commented Apr 6, 2015

Makes it pass these todo spec tests:

  • libsass/var-args
  • scss-tests/071_test_mixin_splat_args_with_var_args_preserves_separator
  • scss-tests/090_test_function_splat_args_with_var_args_preserves_separator

@mgreter mgreter added this to the 3.2 milestone Apr 6, 2015
@mgreter mgreter self-assigned this Apr 6, 2015
@mgreter mgreter force-pushed the bugfix/preserve-separator-with-varargs branch 2 times, most recently from 0c7bbee to 2421ef0 Compare April 6, 2015 18:01
@coveralls
Copy link

Coverage Status

Coverage increased (+0.07%) to 80.63% when pulling 2421ef0 on mgreter:bugfix/preserve-separator-with-varargs into f82a41b on sass:master.

@mgreter mgreter modified the milestones: 3.2.1, 3.2 Apr 8, 2015
@mgreter mgreter mentioned this pull request Apr 30, 2015
Closed
9 tasks
@mgreter mgreter force-pushed the bugfix/preserve-separator-with-varargs branch from 2421ef0 to 7dc9f16 Compare April 30, 2015 01:49
@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 80.28% when pulling 7dc9f16 on mgreter:bugfix/preserve-separator-with-varargs into 9ad775f on sass:master.

@xzyfer xzyfer modified the milestones: 3.2.2, 3.3 May 1, 2015
@mgreter mgreter modified the milestones: 3.2.3, 3.3 May 7, 2015
@mgreter mgreter force-pushed the bugfix/preserve-separator-with-varargs branch from 7dc9f16 to ae310a7 Compare May 7, 2015 22:56
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.12%) to 80.21% when pulling ae310a7 on mgreter:bugfix/preserve-separator-with-varargs into 66631c0 on sass:master.

@xzyfer
Copy link
Contributor

xzyfer commented May 8, 2015

👍

mgreter added a commit to mgreter/libsass that referenced this pull request May 8, 2015
@mgreter
Merge fixes and features for 3.2.3
f802410 
- sass#1050
- sass#1164
- sass#1165
- sass#1166
- sass#1172
- sass#1173
- sass#1174
- sass#1175
- sass#1176
@mgreter mgreter merged commit ae310a7 into sass:master May 8, 2015
@mgreter mgreter deleted the bugfix/preserve-separator-with-varargs branch July 28, 2015 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mgreter mgreter

Labels
Dev - PR Ready Dev - Test Written
Projects
None yet
Milestone
3.2.3
Development

Successfully merging this pull request may close these issues.
3 participants
@mgreter @coveralls @xzyfer