Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom properties with colour names shouldn't be substituted for hex values #2140

Closed
xzyfer opened this issue Aug 4, 2016 · 1 comment
Closed

Comments

@xzyfer
Copy link
Contributor

xzyfer commented Aug 4, 2016

Originally reported by @alisamar in sass/node-sass#1624

:root {
  --teal: #444;
}

a { content: var(--teal) }
b { content: (- red) }
c { content: (+- blue) }
d { content: (-green) }
e { content: (+ yellow) }

Ruby Sass 3.4.21

:root {
  --teal: #444; }

a {
  content: var(--teal); }

b {
  content: -red; }

c {
  content: +-blue; }

d {
  content: -green; }

e {
  content: +yellow; }

LibSass 3.3.7

:root {
  --teal: #444; }

a {
  content: var(--#008080); }

b {
  content: -#ff0000; }

c {
  content: +-#0000ff; }

d {
  content: -#008000; }

e {
  content: +#ffff00; }

Spec added sass/sass-spec#889

@xzyfer xzyfer added this to the 3.4 milestone Aug 4, 2016
xzyfer added a commit to xzyfer/sass-spec that referenced this issue Aug 4, 2016
@nickautomatic
Copy link

nickautomatic commented Aug 31, 2016

Until a fix for this is rolled out, is there a temporary solution or workaround at all? eg. is there an older version that didn't have this issue? We were using custom properties (with gulp-sass) a couple of months ago with no problem, but now we get this sort of conversion (--white--#ffffff) happening each time, which makes me wonder if this issue has crept in recently.

xzyfer added a commit to xzyfer/sass-spec that referenced this issue Sep 25, 2016
xzyfer added a commit to xzyfer/libsass that referenced this issue Sep 25, 2016
xzyfer added a commit to xzyfer/libsass that referenced this issue Sep 25, 2016
xzyfer added a commit to xzyfer/libsass that referenced this issue Sep 25, 2016
xzyfer added a commit to xzyfer/sass-spec that referenced this issue Sep 25, 2016
xzyfer added a commit to xzyfer/libsass that referenced this issue Sep 25, 2016
xzyfer added a commit to xzyfer/sass-spec that referenced this issue Sep 25, 2016
xzyfer added a commit to xzyfer/sass-spec that referenced this issue Sep 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants