Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Variables in at-directives should not be evaluated #1253

Closed
xzyfer opened this issue May 31, 2015 · 1 comment
Closed

Variables in at-directives should not be evaluated #1253

xzyfer opened this issue May 31, 2015 · 1 comment

Comments

@xzyfer
Copy link
Contributor

xzyfer commented May 31, 2015

Ref #1214

The content of generic at-directives should be a simple string constant. Currently we parse these values and evaluate them which is not how Ruby Sass behaves.

$foo: bar;
@keyframes $foo {
  from { a: b }
  to { a: c }
}

Ruby Sass

@keyframes $foo {
  from {
    a: b; }
  to {
    a: c; } }

Libsass

@keyframes bar{
  from {
    a: b; }
  to {
    a: c; } }

Spec added: sass/sass-spec#387

@mgreter
Copy link
Contributor

mgreter commented Jul 13, 2015

We now have a passing spec test since #1249 was merged 🎈

@mgreter mgreter closed this as completed Jul 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants