Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate user-defined functions with math function names #2068

Closed
wants to merge 1 commit into from

Conversation

nex3
Copy link
Contributor

@nex3 nex3 commented Aug 17, 2023

@nex3 nex3 requested a review from Goodwine August 17, 2023 22:52
'with the new\n'
'CSS $name() syntax. $suggestion\n'
'\n'
'More info: https:/sass-lang.com/d/math-fn-name',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only nit is that this page is not live yet, but I understand it should go live soon

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh actually on second look, there is a missing /

Suggested change
'More info: https:/sass-lang.com/d/math-fn-name',
'More info: https://sass-lang.com/d/math-fn-name',

'with the new\n'
'CSS $name() syntax. $suggestion\n'
'\n'
'More info: https:/sass-lang.com/d/math-fn-name',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh actually on second look, there is a missing /

Suggested change
'More info: https:/sass-lang.com/d/math-fn-name',
'More info: https://sass-lang.com/d/math-fn-name',

@nex3
Copy link
Contributor Author

nex3 commented Aug 29, 2023

Closing this out in favor of the approach described in sass/sass#3661

@nex3 nex3 closed this Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants