Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve sass --embedded performance #2013

Merged
merged 15 commits into from
Sep 1, 2023
Merged

Improve sass --embedded performance #2013

merged 15 commits into from
Sep 1, 2023

Commits on Aug 24, 2023

  1. Persist isolates and use mailbox

    @ntkme
    ntkme committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    017a0a3 View commit details
    Browse the repository at this point in the history

Commits on Aug 25, 2023

  1. Code review

    @ntkme
    ntkme committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    c433915 View commit details
    Browse the repository at this point in the history

  2. Code review

    @ntkme
    ntkme committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    fb75b9f View commit details
    Browse the repository at this point in the history

  3. Remove break from non-empty case statement for Dart 3

    @ntkme
    ntkme committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    297a5bd View commit details
    Browse the repository at this point in the history

  4. Split long line

    @ntkme
    ntkme committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    295e39a View commit details
    Browse the repository at this point in the history

  5. Use a mutate method instead of mutate properties

    @ntkme
    ntkme committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    514f8bc View commit details
    Browse the repository at this point in the history

  6. Split long lines

    @ntkme
    ntkme committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    83b666f View commit details
    Browse the repository at this point in the history

  7. Update docs

    @ntkme
    ntkme committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    47fe1cd View commit details
    Browse the repository at this point in the history

  8. Remove unnecessary default value

    @ntkme
    ntkme committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    29b3658 View commit details
    Browse the repository at this point in the history

  9. Wrap ProtocolError in host calls as AsyncError and propagate AsyncErr… 

    …or to top level
    @ntkme
    ntkme committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    43fc8e5 View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2023

  1. Refactor _Lease into a ReusableIsolate class 

    This encapsulates the logic of repurposing an existing isolate
connection to minimize mutability. Instead, messages from the isolate
are exposed as a separate Stream for each compilation.
    @nex3
    nex3 committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    2a39e08 View commit details
    Browse the repository at this point in the history

  2. Revert "Wrap ProtocolError in host calls as AsyncError and propagate … 

    …AsyncError to top level"

This reverts commit 43fc8e5.
    @ntkme
    ntkme committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    17064b5 View commit details
    Browse the repository at this point in the history

  3. Rename _asyncError to _requestError

    @ntkme
    ntkme committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    ae9c7fd View commit details
    Browse the repository at this point in the history

  4. Code review

    @ntkme
    ntkme committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    4d8839e View commit details
    Browse the repository at this point in the history

Commits on Sep 1, 2023

  1. Style/documentation tweaks

    @nex3
    nex3 committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    37ac4e9 View commit details
    Browse the repository at this point in the history