Loosen trait bound for pretty printing #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #88 +/- ##
=====================================
Coverage 62.5% 62.5%
=====================================
Files 8 8
Lines 470 470
Branches 149 149
=====================================
Hits 294 294
Misses 52 52
Partials 124 124 |
The value type is required to implement `Debug` OR `Display` to be pretty-printed. Those trait bounds are checked on pretty-printing, so `T: Debug` should not be enforced when creating a proxy object.
lo48576
force-pushed
the
feature/loosen-pretty-print-trait-bound
branch
from
891893c
to
d8d64c3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NodeId::debug_pretty_print()introduced by #87 requiresT: Debug, but it should not be checked there since the value types such thatT: !Debug + Displayare also supported.It is safe to remove the trait bound here since
impl<T: {Debug, Display}> {Debug, Display} for DebugPrettyPrint<'_, T>requires necessary trait to be implemented.This patch removes unnecessary trait bound from
NodeId::debug_pretty_print().