Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement FusedIterator for all iterator types #73

Merged
merged 1 commit into from
May 19, 2021

Conversation

lo48576
Copy link
Contributor

@lo48576 lo48576 commented May 18, 2021

All iterator types provided by this crate traverses nodes or edges, and they return None forever once the traversal is done.
For such iterators, it is recommended to implement FusedIterator trait to make iter.fuse() efficient.
See rustdoc for core::iter::FusedIterator.

All iterator types provided by this crate traverses nodes or edges, and
they return `None` forever once the traversal is done.
For such iterators, it is recommended to implement `FusedIterator` trait
to make `iter.fuse()` efficient.
See rustdoc for `core::iter::FusedIterator`.
@lo48576
Copy link
Contributor Author

lo48576 commented May 18, 2021

clippy lint fails at the code I didn't modify.
Can I ignore it in this PR?

@codecov
Copy link

codecov bot commented May 18, 2021

Codecov Report

Merging #73 (9a21777) into master (806014f) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master     #73   +/-   ##
======================================
  Coverage    88.5%   88.5%           
======================================
  Files          10      10           
  Lines         829     829           
======================================
  Hits          734     734           
  Misses         95      95           

@saschagrunert
Copy link
Owner

Yes, I'll fix it later on. Thank you!

@saschagrunert saschagrunert merged commit 18f51cf into saschagrunert:master May 19, 2021
@lo48576 lo48576 deleted the feature/fused-iter branch September 22, 2022 04:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants