feat(core): document store loader - swr in edit state #7552
+50
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
|
No changes to documentation |
pedrobonamin
force-pushed
the
document-store-loader-quicklru
branch
from
597cbf3
to
7e57e56
Compare
|
Component Testing Report Updated Oct 8, 2024 3:12 PM (UTC) ✅ All Tests Passed -- expand for details
|
pedrobonamin
force-pushed
the
document-store-loader-quicklru
branch
from
7e57e56
to
b219e8d
Compare
pedrobonamin
force-pushed
the
document-store-loader-quicklru
branch
from
b219e8d
to
79bc6c8
Compare
pedrobonamin
force-pushed
the
document-store-loader-quicklru
branch
from
79bc6c8
to
e1fda2c
Compare
pedrobonamin
changed the title
…ore" This reverts commit 72a05a7.
bjoerge
force-pushed
the
document-store-loader-quicklru
branch
from
8f6b665
to
dba471c
Compare
bjoerge
previously approved these changes
Oct 8, 2024
| id: idPair.publishedId, | ||
| type: typeName, | ||
| draft: draftSnapshot, | ||
| published: publishedSnapshot, | ||
| liveEdit, | ||
| ready: true, | ||
| transactionSyncLock, | ||
| ready: !fromCache, |
There was a problem hiding this comment.
would it make sense to pass fromCache as a separate property on EditState? The granularity might be useful in certain cases (can do this later if the need arises though)
bjoerge
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds in memory swr cache to the documents edit state, allowing us to render them immediately when you open the form instead of having to wait for it to be fully loaded again.
It works for the following case:
Screen.Recording.2024-09-27.at.12.14.41.mov
What to review
Is this the right approach? Any side effects to consider that hasn't been considered here?
Testing
Existing tests have been updated with the changes introduced.
Notes for release
Adds swr cache for document edits state, navigating between previously visited documents in the studio is now instant