-
Notifications
You must be signed in to change notification settings - Fork 421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(core): end "Array Tree Editing" beta #7411
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
No changes to documentation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just think we're missing one property for deprecation and otherwise everything looks ok :)
good work and thanks for doing this!
Component Testing Report Updated Aug 22, 2024 12:17 PM (UTC) ✅ All Tests Passed -- expand for details
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's goo!
@@ -42,17 +42,17 @@ test(`file drop event should not propagate to dialog parent`, async ({ | |||
|
|||
// Open the dialog. | |||
await page.getByRole('button', {name: fileName}).click() | |||
await expect(page.locator('#tree-editing-dialog')).toBeVisible() | |||
await expect(page.getByRole('dialog')).toBeVisible() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test file has been updated to how it was before the array tree editing feature
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
* chore(core): end "Array Tree Editing" beta * chore(tests): skip tree editing tests * chore(types): deprecate treeEditing option in arrays * fix(tests): revert array tests to before tree editing dialog
Description
This changes disable the "Array Tree Editing" beta feature for everyone, even those that opted in to the beta.
Deprecates the beta flag
treeArrayEditing
What to review
Testing
Notes for release
In version 3.50.0 a month ago we launched a beta of an experimental modal for editing nested objects in arrays. Thank you to everyone who opted in to the beta and gave us valuable feedback on the user experience. We are now ending the experiment and we continue working on alternative ways to navigate nested structured content.