refactor(sanity): Move date inputs UI Components to ui-components

[RitaDias]

Description

As part of the content releases changes, we're moving part of the date picker ui components to the ui-component folder

What to review

Does this make sense?
Should I have moved other things / did I move things that I shouldn't have?

Testing

The original tests should be good enough

Notes for release

N/A

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
page-building-studio	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Aug 22, 2024 9:16am
performance-studio	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Aug 22, 2024 9:16am
test-compiled-studio	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Aug 22, 2024 9:16am
test-next-studio	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Aug 22, 2024 9:16am
test-studio	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Aug 22, 2024 9:16am

1 Skipped Deployment

Name	Status	Preview	Comments	Updated (UTC)
studio-workshop	⬜️ Ignored (Inspect)			Aug 22, 2024 9:16am

[github-actions]

No changes to documentation

[github-actions]

Component Testing Report Updated Aug 22, 2024 9:33 AM (UTC)

❌ Failed Tests (1) -- expand for details

File	Status	Duration	Passed	Skipped	Failed
comments/CommentInput.spec.tsx	✅ Passed (Inspect)	43s	15	0	0
formBuilder/ArrayInput.spec.tsx	✅ Passed (Inspect)	8s	3	0	0
formBuilder/inputs/PortableText/Annotations.spec.tsx	✅ Passed (Inspect)	31s	6	0	0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx	✅ Passed (Inspect)	36s	11	7	0
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx	✅ Passed (Inspect)	0s	0	12	0
formBuilder/inputs/PortableText/Decorators.spec.tsx	✅ Passed (Inspect)	17s	6	0	0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx	✅ Passed (Inspect)	10s	3	0	0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx	✅ Passed (Inspect)	3m 0s	0	0	0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx	✅ Passed (Inspect)	44s	15	0	0
formBuilder/inputs/PortableText/Input.spec.tsx	✅ Passed (Inspect)	1m 49s	21	0	0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx	✅ Passed (Inspect)	1m 15s	18	0	0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx	✅ Passed (Inspect)	8s	3	9	0
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx	✅ Passed (Inspect)	25s	9	0	0
formBuilder/inputs/PortableText/Styles.spec.tsx	✅ Passed (Inspect)	18s	6	0	0
formBuilder/inputs/PortableText/Toolbar.spec.tsx	❌ Failed (Inspect)	1m 25s	20	0	1
formBuilder/tree-editing/TreeEditing.spec.tsx	✅ Passed (Inspect)	1m 48s	30	0	0
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx	✅ Passed (Inspect)	20s	3	0	0

[ricokahler]

this looks good but i wonder if we should add some boundary linting similar to how we disallow relative imports from core inside of structure.

is the ui-components folder new? (if it's not new then ignore this comment) should that also have import boundary linting? is it an issue if a component within the ui-components folder imports from other places?

if so can u update this PR to include updating the eslint boundary rules?

[RitaDias]

this looks good but i wonder if we should add some boundary linting similar to how we disallow relative imports from core inside of structure.

is the ui-components folder new? (if it's not new then ignore this comment) should that also have import boundary linting? is it an issue if a component within the ui-components folder imports from other places?

if so can u update this PR to include updating the eslint boundary rules?

The ui-components folder is not new, we've had it for a while and we do want to use it in core (like the comments and tasks use the buttom from the ui-components folder vs the sanity ui ones because they are more opiniated ) :)

[bjoerge]

is the ui-components folder new? (if it's not new then ignore this comment) should that also have import boundary linting? is it an issue if a component within the ui-components folder imports from other places?

This is a really good point – the way we import this currently doesn't seem quite right at first glance. But this PR isn't really changing any of that, so let's look into this separately?

[bjoerge]

Very nice, thanks @RitaDias!