-
Notifications
You must be signed in to change notification settings - Fork 421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core): update eslintrc config to show no-restricted-imports rules #7367
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
No changes to documentation |
Component Testing Report Updated Aug 14, 2024 8:07 AM (UTC)
|
@@ -138,7 +139,6 @@ export function TreeEditingSearch(props: TreeEditingSearchProps): JSX.Element { | |||
|
|||
return ( | |||
<StyledPopover | |||
animate |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the default in the ui-components
popover
@@ -219,6 +225,7 @@ export function TreeEditingDialog(props: TreeEditingDialogProps): JSX.Element | | |||
<Card borderTop> | |||
<Flex align="center" justify="flex-end" paddingX={3} paddingY={2} sizing="border"> | |||
<Button | |||
size="large" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The large ui-components
button equals to the default size of the button imported from @sanity/ui
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and double checked with the modal and everything looks good :)
The only thing I don't know a whole lot about is the setting up of the linting but it looks good to me as well!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch! thanks for fixing it
…#7367) * fix(core): update eslintrc config to show no-restricted-imports rules * fix(core): change rule path to its original value
Description
The existing eslint config is overriding the original
no-restricted-imports
rule.When this rule was added:
The previous rules stopped working.
no-restricted-imports
rules work at the same time.With the changes introduced, now we are seeing all the expected errors.
What to review
Testing
Create a .tsx file inside
packages/sanity/*
and add the following code, the errors should show in the file and when running the lint check action.Notes for release